Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(memory leak): array buffer was sticking around because of exception #748

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

sedghi
Copy link
Member

@sedghi sedghi commented Aug 21, 2023

Context

purge cache was not freeing up memory since the deactivate texture calls had an exception which caused the scalardata to hang around

Changes & Results

re-order the destroy calls

Testing

after
CleanShot 2023-08-21 at 18 41 38

Before
CleanShot 2023-08-21 at 18 44 00

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] "OS:
  • [] "Node version:
  • [] "Browser:

@netlify
Copy link

netlify bot commented Aug 21, 2023

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit ea416f0
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/64e3e8f5de930d0008ba6831
😎 Deploy Preview https://deploy-preview-748--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sedghi sedghi merged commit f27ae9a into main Aug 21, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant