Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link textbox to vertex unless moved by user #651

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

IbrahimCSAE
Copy link
Collaborator

Context

In the angle tool the label for degrees is not linked to the vertex of the angle... this can be confusing as the line that links to the label is similar to the lines of the angle and it can appear that you've drawn some other shape rather than an angle.

image

Changes & Results

Now by default, the textbox line is linked to the vertex, and it will stay that way unless the text box is specifically moved by the user so that they still have that option if they want it.

Before:-

before

After:-

Screenshot_2

Testing

  • Go to the examples directory in the repo
  • Use the double click with stack annotations tool example to test the angle tool

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • "OS: Windows 10
  • "Node version: 18.15.0
  • "Browser: Chrome

@netlify
Copy link

netlify bot commented Jun 12, 2023

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit bd0ea83
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/6487536d50f64b0008a3736b
😎 Deploy Preview https://deploy-preview-651--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Collaborator

@wayfarer3130 wayfarer3130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sedghi - I think this is cleaner/more obvious, but it is a UI change so I wanted to let you see the update and approve/merge it as you will.

@sedghi sedghi merged commit d77dff3 into cornerstonejs:main Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants