Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected "any" types in tools type definitions #506

Open
StefanNedelchev opened this issue Mar 22, 2023 · 2 comments
Open

Unexpected "any" types in tools type definitions #506

StefanNedelchev opened this issue Mar 22, 2023 · 2 comments

Comments

@StefanNedelchev
Copy link
Contributor

StefanNedelchev commented Mar 22, 2023 •
edited
Loading

The type of toolName for all tools is any instead of string. This becomes an issue if for people who use @typescript-eslint configuration with strict type checking (flagging @typescript-eslint/no-unsafe-argument or @typescript-eslint/no-unsafe-assignment errors).

image

The configuration property (also seen on screenshot) is also weekly typed. If using Record<string, any> is a temporary solution until types are completely ported from the legacy repo, please ignore me :)
@sedghi
Copy link
Member

sedghi commented Mar 23, 2023

I think that is a side effect of the way we fixed the issue with No static block, see this PR #179

@StefanNedelchev
Copy link
Contributor Author

@sedghi so what could be the best solution? Going after each toolName property manually?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sedghi @StefanNedelchev