From c2ed6275ccb80fbbab3c0f9c67893d6b681b0bab Mon Sep 17 00:00:00 2001
From: Davide Punzo <punzodavide@hotmail.it>
Date: Thu, 3 Feb 2022 17:44:42 +0100
Subject: [PATCH] fix: bug tolerance parameter was not propagated (#241)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* fix: 🐛 IDC Re #2003: fix regression in parsing segmentation orietations

* fix: 🐛 fix array format regression from commit 70b24332783d63c9db2ed21d512d9f7b526c5222

* fix: 🐛 force a release for commit caaac4bead91f34dd393208a7b47180923c915b4

* fix: 🐛 force a release for commit caaac4bead91f34dd393208a7b47180923c915b4

* fix: 🐛 tolerance parameter was not propagated

* fix var description
---
 .../adapters/src/adapters/Cornerstone/Segmentation.js | 11 ++++++++---
 .../src/adapters/Cornerstone/Segmentation_4X.js       |  3 ++-
 2 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/packages/adapters/src/adapters/Cornerstone/Segmentation.js b/packages/adapters/src/adapters/Cornerstone/Segmentation.js
index 9ed1ec82b..53483465b 100644
--- a/packages/adapters/src/adapters/Cornerstone/Segmentation.js
+++ b/packages/adapters/src/adapters/Cornerstone/Segmentation.js
@@ -52,6 +52,10 @@ function generateSegmentation(
  * @param  {string[]} imageIds    An array of the imageIds.
  * @param  {ArrayBuffer} arrayBuffer The SEG arrayBuffer.
  * @param {*} metadataProvider
+ * @param  {bool} skipOverlapping - skip checks for overlapping segs, default value false.
+ * @param  {number} tolerance - default value 1.e-3.
+ * @param  {number} cornerstoneToolsVersion - default value 4.
+ *
  * @returns {Object}  The toolState and an object from which the
  *                    segment metadata can be derived.
  */
@@ -60,6 +64,7 @@ function generateToolState(
     arrayBuffer,
     metadataProvider,
     skipOverlapping = false,
+    tolerance = 1e-3,
     cornerstoneToolsVersion = 4
 ) {
     if (cornerstoneToolsVersion === 4) {
@@ -67,7 +72,8 @@ function generateToolState(
             imageIds,
             arrayBuffer,
             metadataProvider,
-            skipOverlapping
+            skipOverlapping,
+            tolerance
         );
     }
 
@@ -75,8 +81,7 @@ function generateToolState(
         return Segmentation_3X.generateToolState(
             imageIds,
             arrayBuffer,
-            metadataProvider,
-            skipOverlapping
+            metadataProvider
         );
     }
 
diff --git a/packages/adapters/src/adapters/Cornerstone/Segmentation_4X.js b/packages/adapters/src/adapters/Cornerstone/Segmentation_4X.js
index 2a4d89aba..63e2feeb7 100644
--- a/packages/adapters/src/adapters/Cornerstone/Segmentation_4X.js
+++ b/packages/adapters/src/adapters/Cornerstone/Segmentation_4X.js
@@ -262,7 +262,8 @@ function _createSegFromImages(images, isMultiframe, options) {
  * @param  {string[]} imageIds - An array of the imageIds.
  * @param  {ArrayBuffer} arrayBuffer - The SEG arrayBuffer.
  * @param  {*} metadataProvider.
- * @param  {number} tolerance - checks tolerance, default value 1.e-3.
+ * @param  {bool} skipOverlapping - skip checks for overlapping segs, default value false.
+ * @param  {number} tolerance - default value 1.e-3.
  *
  * @return {[]ArrayBuffer}a list of array buffer for each labelMap
  * @return {Object} an object from which the segment metadata can be derived