Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add annotation completed event #84

Merged
merged 3 commits into from
Apr 26, 2022
Merged

feat: Add annotation completed event #84

merged 3 commits into from
Apr 26, 2022

Conversation

sedghi
Copy link
Member

@sedghi sedghi commented Apr 26, 2022 •
edited
Loading

Add annotation completed event

@sedghi sedghi changed the title Feat/measurement completed feat: Add annotation completed event Apr 26, 2022
@sedghi sedghi requested a review from JamesAPetts April 26, 2022 03:22
JamesAPetts
JamesAPetts requested changes Apr 26, 2022
View reviewed changes
Copy link
Member

@JamesAPetts JamesAPetts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stuff we got here is great for normal completion, but we've missed cancel.

Annotations persist on cancel, and we then still need to trigger the measurement completed event.

JamesAPetts
JamesAPetts approved these changes Apr 26, 2022
View reviewed changes
Copy link
Member

@JamesAPetts JamesAPetts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@sedghi sedghi merged commit cd574da into main Apr 26, 2022
@swederik swederik deleted the feat/measurement-completed branch July 8, 2022 09:33
@xiaoxiao5
Copy link

The ANNOTATION tool does not trigger events such as ANNOTATION COMPLETED
image
cornerstone3D-beta-1.1.5
@sedghi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swederik swederik swederik approved these changes

@JamesAPetts JamesAPetts JamesAPetts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sedghi @xiaoxiao5 @swederik @JamesAPetts