fix: jumpToSlice and scaling of images in renderToCanvas #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sedghi
changed the title
JamesAPetts
requested changes
Apr 19, 2022
There was a problem hiding this comment.
Some minor comments to address, but otherwise good.
How are we doing publishing of cornerstone3D beta btw? We are still currently changing public API a lot during this phase, but we shouldn't increment major versions until its out of beta. Do we make each breaking change a feature change. I.e. 0.X.0.?
| ): void { | ||
| const annotationManager = getViewportSpecificAnnotationManager(element); | ||
| let annotationManager = getDefaultAnnotationManager(); | ||
| if (element) { |
There was a problem hiding this comment.
I think this is a great solution that makes sense, allows us to have the annotation-only-api whilst also allowing for element specific managers if we ever need them. I know @swederik is away, but want to tag him for visibility about this decision (sure we can merge before he sees it, can always make another change).
packages/tools/src/utilities/stackScrollTool/scrollThroughStack.ts
Outdated
Show resolved
Hide resolved
JamesAPetts
reviewed
Apr 19, 2022
JamesAPetts
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removeAnnotationfor the annotation to get removedrenderToCanvasfunctionscrollThroughStackutility and fix the problem with deltaFrames = 0 by caching previous direction