Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cachedStats to store imageId and volumeId #75

Merged
merged 6 commits into from
Apr 13, 2022
Merged

feat: cachedStats to store imageId and volumeId #75

merged 6 commits into from
Apr 13, 2022

Conversation

sedghi
Copy link
Member

@sedghi sedghi commented Apr 13, 2022 •
edited
Loading

  • CachedStats for annotations now stores the stats based on either imageId:theImageIdWithLoaderScheme for stack targets or volumeId:theVolumeIdWIthLoaderScheme
    • This makes consumer apps to better organize and decipher where the annotation is coming from (acquisition plane stack or volume, OR reconstructed planes with no referencedImageIds
  • Better handling of invalidating stack annotations in the presence of the volume annotation manipulation in the same FoR

JamesAPetts
JamesAPetts approved these changes Apr 13, 2022
View reviewed changes
Copy link
Member

@JamesAPetts JamesAPetts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor suggestion.

packages/core/src/RenderingEngine/StackViewport.ts Outdated Show resolved Hide resolved
@sedghi sedghi merged commit a2404c4 into main Apr 13, 2022
@swederik swederik deleted the fix/stackTargetId branch July 8, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesAPetts JamesAPetts JamesAPetts approved these changes

@swederik swederik Awaiting requested review from swederik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sedghi @JamesAPetts