fix js exception when setting invertRgbTransferFunction. safe program… #595
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
sedghi
reviewed
May 4, 2023
| @@ -20,6 +20,11 @@ | |||
| export default function invertRgbTransferFunction( | |||
| rgbTransferFunction: any | |||
| ): void { | |||
| // cut in case there is no function at all | |||
| if (rgbTransferFunction) { | |||
There was a problem hiding this comment.
did you mean if (!rgbTransferFunction) ?
There was a problem hiding this comment.
yes eagle eyes, thank you
sedghi
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ming only
Safe programming only. This does add any new feature just prevent exceptions
The scenario to occur this is:
Expected:
Actual
Tech inputs.
This occurs because loading another frame will cause a new vtk Object to be generated so transfer function is not yet set when we try to reapply it on https://github.com/cornerstonejs/cornerstone3D-beta/blob/main/packages/core/src/RenderingEngine/StackViewport.ts#L1149