fix: Segmentation slice range is wrong when nearly orthonormal as well as for segmentation volumes #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cornerstone-3d-docs canceled.
|
sedghi
reviewed
Mar 23, 2023
packages/core/src/utilities/getTargetVolumeAndSpacingInNormalDir.ts
Outdated
Show resolved
Hide resolved
sedghi
reviewed
Mar 23, 2023
sedghi
reviewed
Mar 23, 2023
wayfarer3130
force-pushed
the
fix/segmentation-slice-range
branch
from
f67024a
to
535c3dd
Compare
sedghi
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a segmentation is created with a much larger range than one of the display sets it applies to, then that display set is shown with large swathes of black, and the scrolling can be wrong because it uses the finer of the two scrolls, which can end up duplicating base images.
This change uses primary volumes, which it determines by those having a volume image loader prefix, for slice range, and only uses secondary volumes when there are no primaries.