feat(volume3d): add orientation to volume viewport 3d #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
jbocce
reviewed
Mar 15, 2023
|
|
||
| const activeCamera = this.getVtkActiveCamera(); | ||
|
|
||
| if (parallelProjection != null) { | ||
| activeCamera.setParallelProjection(parallelProjection); | ||
| } | ||
|
|
||
| if (orientation && orientation !== OrientationAxis.ACQUISITION) { |
There was a problem hiding this comment.
Actually... does it make sense to refactor this code and put it in the BaseVolumeViewport constructor? That is move it there and remove it from here and in VolumeViewport?
There was a problem hiding this comment.
Perhaps I was not clear... apologies. Why not put the whole if block (i.e. lines 37-40) in the BaseVolumeViewport constructor?
There was a problem hiding this comment.
because one has a early return but more logic later
jbocce
reviewed
Mar 16, 2023
|
|
||
| const activeCamera = this.getVtkActiveCamera(); | ||
|
|
||
| if (parallelProjection != null) { | ||
| activeCamera.setParallelProjection(parallelProjection); | ||
| } | ||
|
|
||
| if (orientation && orientation !== OrientationAxis.ACQUISITION) { |
There was a problem hiding this comment.
Perhaps I was not clear... apologies. Why not put the whole if block (i.e. lines 37-40) in the BaseVolumeViewport constructor?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add
Orientationto volume viewport 3D