feat(scrollEvent): added out of bounds scroll

[Ouwen]

This adds an event for when user stack scroll goes out of bounds

[netlify]

✅ Deploy Preview for cornerstone-3d-docs canceled.

Name	Link
🔨 Latest commit	024590b
🔍 Latest deploy log	https://app.netlify.com/sites/cornerstone-3d-docs/deploys/6425c3249b5d1a0008fe46fa

[sedghi]

can you add these to the EventTypes too?

[sedghi]

can you add the exports you want from the getVolumeViewportScrollInfo so that we don't recomute these again?

[sedghi]

see my comments

[Ouwen]

@sedghi this is ready for your review

[sedghi]

I"m a little bit confused, isn't it the fact that this function relies on the sliceRangeInfo that is calculated above? So can we refactor its logic so that we don't do sliceRangeInfo getter again?

function getVolumeViewportScrollInfo(
  viewport: IVolumeViewport,
  volumeId: string
) {
  const { sliceRange, spacingInNormalDirection } = getVolumeSliceRangeInfo(
    viewport,
    volumeId
  );

  const { min, max, current } = sliceRange;

  // Now we can see how many steps there are in this direction
  const numScrollSteps = Math.round((max - min) / spacingInNormalDirection);

  // Find out current frameIndex
  const fraction = (current - min) / (max - min);
  const floatingStepNumber = fraction * numScrollSteps;
  const currentStepIndex = Math.round(floatingStepNumber);

  return { numScrollSteps, currentStepIndex };
}

to

function getVolumeViewportScrollInfoFromSliceRange(
  sliceRange,
  spacingInNormalDirection
) {
  const { min, max, current } = sliceRange;

  // Now we can see how many steps there are in this direction
  const numScrollSteps = Math.round((max - min) / spacingInNormalDirection);

  // Find out current frameIndex
  const fraction = (current - min) / (max - min);
  const floatingStepNumber = fraction * numScrollSteps;
  const currentStepIndex = Math.round(floatingStepNumber);

  return { numScrollSteps, currentStepIndex };
}

[Ouwen]

@sedghi let me know what you think of the change I made. I just export the sliceRangeInfo from getVolumeViewportScrollInfo

[sedghi]

API check failed

[Ouwen]

Ah yeah I need to build updateapi