fix(scroll): Scrolling failed to find the volume with segmentation #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
sedghi
reviewed
Mar 10, 2023
packages/core/src/utilities/getTargetVolumeAndSpacingInNormalDir.ts
Outdated
Show resolved
Hide resolved
sedghi
approved these changes
Mar 10, 2023
sedghi
changed the title
lscoder
added a commit
to lscoder/cornerstone3D
that referenced
this pull request
Mar 13, 2023
…ack after resolving some conflicts
sedghi
pushed a commit
that referenced
this pull request
Mar 13, 2023
* feat(cine): added support for volumes * feat(cine): 4D volume cine * feat(cine): refactored * feat(cine): clean up * feat(cine): updated CINETool example adding three new viewports * feat(cine): CINE example - 4D volumes * feat(cine): updated CINE example (4D Volume) * feat(cine): stop 4D CINE that was started on another viewport * feat(cine): undid an unintentional change * feat(cine): fixed wrong imports * feat(cine): api files * feat(cine): code review * feat(cine): removed dynamicVolume and added dynamicCINETool (examples page) * feat(cine): moved dynamicCINETool to core section (examples page) * feat(cine): added crosshairs tool * feat(cine): numTimePoints = 5 (default) * feat(cine): Added the changes pushed to #470 (79b8c96) back after resolving some conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On attempting to scroll a second frame of reference series against the original series, the scrolling failed to display.
Also fix a NPE on turning off CINE related to segmentation.