Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] CircleROI tool #459

Merged
merged 17 commits into from
Mar 22, 2023
Merged

[Feat] CircleROI tool #459

merged 17 commits into from
Mar 22, 2023

Conversation

md-prog
Copy link
Contributor

@md-prog md-prog commented Mar 3, 2023

Feature

  • Implementation of CircleROI tool, we had for cornerstonejs

bugfix

  • EllipticalROI tool - when setting the centerPointRadius the drawing gets corrupted
  • RectangleROI, EllipticalROI tool's area sometimes becomes negative

notes

The CircleROI tool can be drawn by pointing center and another point.

@netlify
Copy link

netlify bot commented Mar 3, 2023 •
edited
Loading

✅ Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit bab7407
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/641b44efef36160008fe27af
😎 Deploy Preview https://deploy-preview-459--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@md-prog md-prog marked this pull request as draft March 3, 2023 17:20
@md-prog md-prog marked this pull request as ready for review March 3, 2023 20:58
javaDeveloperZeng pushed a commit to javaDeveloperZeng/cornerstone3D-beta that referenced this pull request Mar 6, 2023
@sedghi
fix: rendering of palette color for no useRGB flag (cornerstonejs#459)
60f8e84
@sedghi sedghi requested a review from wayfarer3130 March 8, 2023 04:05
wayfarer3130
wayfarer3130 approved these changes Mar 22, 2023
View reviewed changes
Copy link
Collaborator

@wayfarer3130 wayfarer3130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me - it looks like it should be able to save and load and display.
I was able to edit the circle, both in radius and position.
Needs an update to match CS3D, but I don't think that will affect any code.

@wayfarer3130 wayfarer3130 merged commit 1c03ed3 into cornerstonejs:main Mar 22, 2023
@md-prog md-prog deleted the feat/circle-roi-3d branch March 22, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wayfarer3130 wayfarer3130 wayfarer3130 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@md-prog @wayfarer3130