fix(StackViewport): Reset camera bug when rotation happens on StackViewport #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…happens on StackViewport For a GPU reset, start by resetting the flips and rotation (via viewUp) because the ordering of the various flips and rotations that have been applied is not known.
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
jbocce
commented
Jan 18, 2023
jbocce
commented
Jan 18, 2023
| @@ -1748,6 +1751,9 @@ class StackViewport extends Viewport implements IStackViewport { | |||
|
|
|||
| this.setCameraNoEvent({ viewUp, viewPlaneNormal }); | |||
|
|
|||
| // Setting this makes the following comment about resetCameraNoEvent not modifying viewUp true. | |||
| this.initialViewUp = viewUp; | |||
|
|
|||
| // Reset the camera to point to the new slice location, reset camera doesn't | |||
There was a problem hiding this comment.
Prior to my changes, this comment was not true. viewUp was getting changed via a call to camera.roll.
sedghi
reviewed
Jan 23, 2023
| @@ -155,6 +155,9 @@ class StackViewport extends Viewport implements IStackViewport { | |||
| public modality: string; // this is needed for tools | |||
| public scaling: Scaling; | |||
|
|
|||
| // Camera properties | |||
| private initialViewUp: Point3; | |||
|
|
|||
There was a problem hiding this comment.
I think we should this.initialViewUp= inside the constructor as well
sedghi
reviewed
Jan 23, 2023
| @@ -1883,7 +1889,14 @@ class StackViewport extends Viewport implements IStackViewport { | |||
| // Todo: we need to make the rotation a camera properties so that | |||
| // we can reset it there, right now it is not possible to reset the rotation | |||
| // without this | |||
| this.getVtkActiveCamera().roll(this.rotationCache); | |||
| if (this.initialViewUp) { | |||
There was a problem hiding this comment.
if you set it in the constructor you don't need this if here, since it will always be defined
sedghi
requested changes
Jan 23, 2023
Thank you. |
sedghi
changed the title
jbocce
deleted the
fix/#372-reset-camera-bug-when-rotation-happens-on-stackViewport
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a GPU reset, start by resetting the flips and rotation (via viewUp) because the ordering of the various flips and rotations that have been applied is not known.