fix: could not access 'index' before initialization

[mmcardle]

Hi,

Working on using cornerstone3d in a Vite project, ran into an issue when running the project.
I think I have narrowed it down to a possibly circular dependency in packages/tools/src/tools/CrosshairsTool.ts when importing liangBarksyClip
Happy to provide an example minimal repository with the error to verify.

Console error

cornerstonejs.bd843ac7.js:18089 Uncaught ReferenceError: Cannot access 'index' before initialization
    at cornerstonejs.bd843ac7.js:18089:29

with index being

...
const { RENDERING_DEFAULTS } = CONSTANTS;
const { liangBarksyClip } = index;
function defaultReferenceLineColor() {
  return "rgb(0, 200, 0)";
}
...

[netlify]

✅ Deploy Preview for cornerstone-3d-docs ready!

Name	Link
🔨 Latest commit	fa8db42
🔍 Latest deploy log	https://app.netlify.com/sites/cornerstone-3d-docs/deploys/63a7795aa2b4380008436f44
😎 Deploy Preview	https://deploy-preview-337--cornerstone-3d-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[santomon]

wow this is incredible! I had the same issue and only just now found the same fix independently;

If only I found your PR a little earlier...

I wonder what's causing this behaviour? the import itself seems logical to me;

On a different note, how did you find this out?

I am just happy to be able to finally work with cornerstone3D in my astro build

[mmcardle]

I have created an example app with the failure here https://github.com/mmcardle/cornerstone-vite

[mmcardle]

wow this is incredible! I had the same issue and only just now found the same fix independently;

If only I found your PR a little earlier...

I wonder what's causing this behaviour? the import itself seems logical to me;

On a different note, how did you find this out?

I am just happy to be able to finally work with cornerstone3D in my astro build

I suspect the issue is with Vite and not with cornerstone3d.

To figure out the problem and fix i used the Contributing Guide on Linking to build my own version of cornerstonejs/tools with the fix in this PR.

When i used this my custom build of cornerstone/tools in my Vite project I stopped getting the error.

[sedghi]

So is this PR fixing your issue with vite?

[mmcardle]

So is this PR fixing your issue with vite?

Yes it does, although I would still like to find the underlying Vite issue as this fix feels like a superficial workaround to delay the import of liangBarksyClip.

[sedghi]

can you try direct import in that file? import liangBarksyClip from '....../utilities/math/vec2/liangBarksyClip

[mmcardle]

can you try direct import in that file? import liangBarksyClip from '....../utilities/math/vec2/liangBarksyClip

Yes that also works, probably a better fix to do the import like that?