Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PlanarFreeHandROI incorrect filtering of annotations within slice #314

Closed
ramonemiliani93 opened this issue Nov 26, 2022 · 0 comments · Fixed by #315
Closed

PlanarFreeHandROI incorrect filtering of annotations within slice #314

ramonemiliani93 opened this issue Nov 26, 2022 · 0 comments · Fixed by #315

Comments

@ramonemiliani93
Copy link
Contributor

As discussed on slack, it seems that the PlanarFreeHandROI tool has its own filterAnnotationsWithinSlice which is only keeping annotations that have the same viewPlaneNormal. The correct implementation is to filter annotations whose view plane normal is not parallel (as implemented in utilities/planar/filterAnnotationsWithinSlice).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Filter PlanarFreeHandROI annotations based on parallel normals instead of equal normals.
1 participant
@ramonemiliani93