Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add stack synchronization within or across studies #291

Merged
merged 2 commits into from
Nov 11, 2022

Conversation

sedghi
Copy link
Member

@sedghi sedghi commented Nov 10, 2022

Add stack synchronization for stack viewports. This works for viewports in the same frame of reference and viewports that are not in the same frame of reference

Make the synchronizer callbacks async

@netlify
Copy link

netlify bot commented Nov 10, 2022

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit 9383c66
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/636d3e67d47f900009e9968d
😎 Deploy Preview https://deploy-preview-291--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sedghi sedghi requested a review from swederik November 10, 2022 18:16
Copy link
Member

@swederik swederik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@sedghi sedghi merged commit f38bec0 into main Nov 11, 2022
NeilMacPhee pushed a commit to NeilMacPhee/cornerstone3D-beta that referenced this pull request Nov 16, 2022
…js#291)

* feat: add stack synchronization within or across studies

* fix: test
wayfarer3130 pushed a commit that referenced this pull request Jan 20, 2023
* added support for specific character set
refactored VR classes
refactored reading/writing ascii and encoded strings
changed hex writing to direct uint8 writing
reimplemented null padded read
removed unused code
unified test data loading and cache the test data locally for faster test runs

* re-enabled test and removed wrong only

* fixed test case that was overlooked

Co-authored-by: flink <florian.link@mevis.fraunhofer.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants