-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3D volume rendering #267
Comments
There are two things here
Happy to review PRs for any of them |
Got it. Thank you very much for the information @sedghi. I will study the VolumeViewport source code to figure out the best way to do this. |
Hi @sedghi. I'm attaching below an image with the git diff of the changes I made just so you have an idea, but this didn't make much of a difference. The first image shows the changes to the I am using the 3d_volume.mp4Sorry to disturb you once again, but could you give me a few pointers? Thank you very much! |
Clipping planes, not clipping range. Remove anywhere we are putting a clipping plane, and let clipping range be actually -infinity to infinity |
Hi @sedghi. Unfortunately, it's still not working. I basically made a change to the I still get pretty much the same behavior I described above. It seems like there is only one visible plane in the front and another one in the back. I can't really understand what's going on. 3d_volume_no_clipping_planes.movThanks for the help! |
That is interesting, most likely our tool is wrong, but I don't see why the initial camera should be wrong too. Can you provide a branch? |
I had some time to look at this, see my branch here, which is just very ugly implementation, but you get the idea, if you can create a PR I would be happy to review it
|
Thank you very much @sedghi! Thank you again! |
Hi @sedghi. I reorganized the code and implemented a new type of viewport called I basically refactored the existing I tried to make my commits easy to understand but let me know if there's anything you'd like me to improve before I submit the pull request. |
This makes sense to me, can you please go ahead and add the PR (mention this issue as well), and I can review and start the discussion there thanks |
* fix(dcmjs):Use a proxy to fix #263 The issue was that there was an accessor being added for a very large integer (0x60030010), causing the array to be that size, but with a null value for everything up to that size. Changed to use a proxy value instead, which allows differentiation by string type, and by whether the underlying object has the original value. * fix(dcmjs):Add a set on addAccessor results unit test.
Hello. I'm a beginner developer. |
@mongsukim Try the implementation in this demo:https://github.com/jianyaoo/vue-cornerstone-demo/blob/main/src/views/basicUsage/Basic3DRender.vue |
@jianyaoo Thank you very much! |
I always encounter the same issue. The error message is as follows:
Which part should I fix?"
I apologize if the question was inappropriate. |
Did you execute the
other, I'm not sure if |
Hi,
I am trying to implement rendering a volume in the way that is displayed in both videos below (the first video was taken from the 3D Slicer program). I couldn't find anything like this in the docs or the examples. Does anyone have a tip on how this could be implemented? I'd just need someone to point me in a direction so I can investigate this further.
I found this example on the VTK.js website that seems to do what I need but I'm not sure how to do these things through Cornerstone3D. It seems like I need to use a
vtkImageMarchingCubes
filter inside a viewport but I'm not sure how it's done.Thank you!
Video 1: https://www.dropbox.com/s/zgn0a7ubugn2jsx/volume_rendering.mp4?dl=0
Video 2: https://www.dropbox.com/s/p0gnoso0u86h1t9/volume.mp4?dl=0
The text was updated successfully, but these errors were encountered: