fix: Add storeAsInitialCamera parameter to StackViewport setCamera #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
This is a simple fix, looks correct to me. @sedghi wasnt sure if I should approve this one, or if you wanted a peak first. |
sedghi
approved these changes
Oct 5, 2022
sedghi
changed the title
storeAsInitialCamera parameter to StackViewport.setCamera
|
Thanks @volrath , this is a great PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reading the API documentation on
StackViewport.setZoomI wanted to try out thestoreAsInitialCameraparameter, but I noticed it wasn't working. Upon further inspection I realized it was due to the fact that, even thoughViewport.setCamerahas said parameter,StackViewportdoesn't, so the the value is never passed down to the super class.Please note that I purposely omitted the parameter from the call to
this.setCameraCPUgiven that I believe it is not used anywhere. Not sure if this is the correct take though, so let me know if this requires further work.