fix(rgba): Handle rgba to rgb conversion based on length #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
wayfarer3130
commented
Sep 16, 2022
| @@ -1341,7 +1341,10 @@ class StackViewport extends Viewport implements IStackViewport { | |||
| const scalars = this._imageData.getPointData().getScalars(); | |||
| const scalarData = scalars.getData() as Uint8Array | Float32Array; | |||
|
|
|||
| if (image.rgba) { | |||
| if (image.rgba || pixelData.length * 3 == scalarData.byteLength * 4) { | |||
There was a problem hiding this comment.
This is a work around for now
sedghi
changed the title
sedghi
approved these changes
Sep 16, 2022
wayfarer3130
pushed a commit
that referenced
this pull request
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work around for the rgba flag not being set correctly and when we have rgba data but need rgb.