Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EllipticalROI Tool - draw center point and make it configurable #190

Closed
md-prog opened this issue Aug 26, 2022 · 0 comments
Closed

EllipticalROI Tool - draw center point and make it configurable #190

md-prog opened this issue Aug 26, 2022 · 0 comments

Comments

@md-prog
Copy link
Contributor

md-prog commented Aug 26, 2022

One Cornerstone-tools v2, we have CircleROI Tool and it has a configuration to draw the center point. : centerPointRadius

We need to replicate the feature to EllipticalROI tool of v3, which is often used as a replacement of CircleROI of v2.
md-prog added a commit to md-prog/cornerstone3D-beta that referenced this issue Aug 26, 2022
@md-prog
cornerstonejs#190 - draw center point of the ellipticalROI tool and m…
534a338 
…ake it configurable
md-prog added a commit to md-prog/cornerstone3D-beta that referenced this issue Aug 26, 2022
@md-prog
cornerstonejs#190 - moved utility function : getCanvasEllipseCenter()…
7a06262 
… to internal, as it changes public api of cornerstone-tools and not quite sure of its usuability in other tools, yet
md-prog added a commit to md-prog/cornerstone3D-beta that referenced this issue Aug 26, 2022
@md-prog
cornerstonejs#190 - removed separate getCanvasEllipseCenter()
17fb399
md-prog added a commit to md-prog/cornerstone3D-beta that referenced this issue Aug 26, 2022
@md-prog
cornerstonejs#190 - ran build:update-api
f8c5aff
md-prog added a commit to md-prog/cornerstone3D-beta that referenced this issue Aug 30, 2022
@md-prog
cornerstonejs#190 - code review fixes
861752f
md-prog added a commit to md-prog/cornerstone3D-beta that referenced this issue Aug 30, 2022
@md-prog
cornerstonejs#190 - update comments of the EllipticalROITool
b6e3ca4
sedghi pushed a commit that referenced this issue Aug 30, 2022
@md-prog
feat: draw center point of the ellipticalROI tool and make it configu…
b0ad00c 
…rable (#191)

* #190 - draw center point of the ellipticalROI tool and make it configurable

* #190 - moved utility function : getCanvasEllipseCenter() to internal, as it changes public api of cornerstone-tools and not quite sure of its usuability in other tools, yet

* #190 - removed separate getCanvasEllipseCenter()

* #190 - ran build:update-api

* #190 - code review fixes

* #190 - update comments of the EllipticalROITool
@sedghi sedghi closed this as completed Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sedghi @md-prog