fix: bug tolerance parameter was not propagated (#241)

* fix: 🐛 IDC Re #2003: fix regression in parsing segmentation orietations * fix: 🐛 fix array format regression from commit 70b24332783d63c9db2ed21d512d9f7b526c5222 * fix: 🐛 force a release for commit caaac4bead91f34dd393208a7b47180923c915b4 * fix: 🐛 force a release for commit caaac4bead91f34dd393208a7b47180923c915b4 * fix: 🐛 tolerance parameter was not propagated * fix var description
cornerstonejs · Feb 3, 2022 · c2ed627 · c2ed627
1 parent f53b630
commit c2ed627
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/packages/adapters/src/adapters/Cornerstone/Segmentation.js b/packages/adapters/src/adapters/Cornerstone/Segmentation.js
@@ -52,6 +52,10 @@ function generateSegmentation(
  * @param  {string[]} imageIds    An array of the imageIds.
  * @param  {ArrayBuffer} arrayBuffer The SEG arrayBuffer.
  * @param {*} metadataProvider
+ * @param  {bool} skipOverlapping - skip checks for overlapping segs, default value false.
+ * @param  {number} tolerance - default value 1.e-3.
+ * @param  {number} cornerstoneToolsVersion - default value 4.
+ *
  * @returns {Object}  The toolState and an object from which the
  *                    segment metadata can be derived.
  */
@@ -60,23 +64,24 @@ function generateToolState(
     arrayBuffer,
     metadataProvider,
     skipOverlapping = false,
+    tolerance = 1e-3,
     cornerstoneToolsVersion = 4
 ) {
     if (cornerstoneToolsVersion === 4) {
         return Segmentation_4X.generateToolState(
             imageIds,
             arrayBuffer,
             metadataProvider,
-            skipOverlapping
+            skipOverlapping,
+            tolerance
         );
     }
 
     if (cornerstoneToolsVersion === 3) {
         return Segmentation_3X.generateToolState(
             imageIds,
             arrayBuffer,
-            metadataProvider,
-            skipOverlapping
+            metadataProvider
         );
     }
 

diff --git a/packages/adapters/src/adapters/Cornerstone/Segmentation_4X.js b/packages/adapters/src/adapters/Cornerstone/Segmentation_4X.js
@@ -262,7 +262,8 @@ function _createSegFromImages(images, isMultiframe, options) {
  * @param  {string[]} imageIds - An array of the imageIds.
  * @param  {ArrayBuffer} arrayBuffer - The SEG arrayBuffer.
  * @param  {*} metadataProvider.
- * @param  {number} tolerance - checks tolerance, default value 1.e-3.
+ * @param  {bool} skipOverlapping - skip checks for overlapping segs, default value false.
+ * @param  {number} tolerance - default value 1.e-3.
  *
  * @return {[]ArrayBuffer}a list of array buffer for each labelMap
  * @return {Object} an object from which the segment metadata can be derived