[CDataTable] Error in objectsAreIdentical with circular obj

[ajm13]

CDataTable uses JSON.stringify in objectsAreIdentical. When items contains objects with circular references, JSON.stringify throws an error, and this will happen every time items or sortedItems changes.

This can be fixed by using a cache and providing a function to JSON.stringify to avoid circular references, like this example:

export const customStringify = function (v: any) {
  const cache = new Map();
  return JSON.stringify(v, function (key, value) {
    if (typeof value === 'object' && value !== null) {
      if (cache.get(value)) {
        // Circular reference found, discard key
        return;
      }
      // Store value in our collection
      cache.set(value, true);
    }
    return value;
  });
};

from here

[woothu]

Hi! Thank you for this report! What is the use case of passing circular objects to items?