Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Replace method to replace rulespec (in specified pos) #87

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

machooo-x
Copy link

This change can support the modification of rules, and there is no conflict for the used items

Copy link
Collaborator

@squeed squeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@squeed
Copy link
Collaborator

squeed commented Jul 26, 2022

Hmm, not sure why checks aren't running. Lemme take a look.

@squeed
Copy link
Collaborator

squeed commented Jul 26, 2022

Let's try... closing and re-opening :-).

@squeed squeed closed this Jul 26, 2022
@squeed squeed reopened this Jul 26, 2022
@squeed
Copy link
Collaborator

squeed commented Jul 26, 2022

@machooo-x can you fix the tests, please?

Copy link
Collaborator

@squeed squeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the tests.

@machooo-x machooo-x requested a review from squeed May 29, 2023 08:59
@machooo-x
Copy link
Author

@machooo-x can you fix the tests, please?

Dear reviewer, hello. I am very sorry for taking so long to resolve this testing issue. Now that I have made changes, could you please take a look and help me merge if possible? If there are any further issues, please let me know and I will definitely solve them. :)

@machooo-x
Copy link
Author

machooo-x commented May 29, 2023

Please fix the tests.

If the test still fails, can you help me solve it conveniently? I can only consider doing this now. Thank you very much.

@squeed
Copy link
Collaborator

squeed commented May 30, 2023

I've re-triggered the tests - let's take a look :-).

@machooo-x
Copy link
Author

I've re-triggered the tests - let's take a look :-).

I'm very sorry for the delay in your time due to my mistake. I have fixed the issue that was just tested, please trigger the test again. : )

@machooo-x
Copy link
Author

Please fix the tests.

Dear reviewer, hello. If it's convenient, please trigger the workflow again and trigger the test. I need your help~~~ : )

@travier
Copy link
Member

travier commented Jun 5, 2023

Can you rebase this PR on top of the latest changes in the repo? This will make it easier to review.

@machooo-x
Copy link
Author

Member

I have added this change to the latest branch. If there are any further issues, please let me know. : )

@machooo-x
Copy link
Author

Can you rebase this PR on top of the latest changes in the repo? This will make it easier to review.

Dear member, if you have time, could you take a look at my changes this time? I want to know if it was successful. If not, I will follow your advice until it is successful.

@squeed squeed closed this Jul 31, 2023
@squeed squeed reopened this Jul 31, 2023
@squeed squeed merged commit b9dff5a into coreos:main Jul 31, 2023
5 checks passed
@machooo-x
Copy link
Author

Dear squeed, will I appear on the list of contributors? @squeed
If so, I would be very happy. : )

@squeed
Copy link
Collaborator

squeed commented Aug 1, 2023

That should happen automatically, unless there's something else you're thinking of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants