Skip to content

Commit

Permalink
Fix iptables stats tests for iptables > 1.8.9
Browse files Browse the repository at this point in the history
IPTables fixed a couple long-standing discrepancies in ipv4/ipv6's -L output.
Unfortunately these fixes break out tests and potentially, stat parsing.

In detail, the following were changed in 1.8.9 and later:
* ip6tables' opt column not outputting spaces instead of dashes
* ip6tables' prot column not resolving "all" to "0", even with numeric mode activated.

Handle them, so that tests keep working post 1.8.9.
  • Loading branch information
costasd committed Oct 16, 2023
1 parent b9dff5a commit 1b5df17
Showing 1 changed file with 14 additions and 9 deletions.
23 changes: 14 additions & 9 deletions iptables/iptables_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -372,15 +372,20 @@ func runRulesTests(t *testing.T, ipt *IPTables) {
}

opt := "--"
if ipt.proto == ProtocolIPv6 {
prot := "0"
if ipt.proto == ProtocolIPv6 &&
ipt.v1 == 1 && ipt.v2 <= 8 && ipt.v3 < 9 {
// this is fixed in iptables 1.8.9 via iptables/6e41c2d874
opt = " "
// this is fixed in iptables 1.8.9 via iptables/da8ecc62dd
prot = "all"
}

expectedStats := [][]string{
{"0", "0", "ACCEPT", "all", opt, "*", "*", subnet1, address1, ""},
{"0", "0", "ACCEPT", "all", opt, "*", "*", subnet2, address2, ""},
{"0", "0", "ACCEPT", "all", opt, "*", "*", subnet2, address1, ""},
{"0", "0", "ACCEPT", "all", opt, "*", "*", address1, subnet2, ""},
{"0", "0", "ACCEPT", prot, opt, "*", "*", subnet1, address1, ""},
{"0", "0", "ACCEPT", prot, opt, "*", "*", subnet2, address2, ""},
{"0", "0", "ACCEPT", prot, opt, "*", "*", subnet2, address1, ""},
{"0", "0", "ACCEPT", prot, opt, "*", "*", address1, subnet2, ""},
}

if !reflect.DeepEqual(stats, expectedStats) {
Expand All @@ -400,10 +405,10 @@ func runRulesTests(t *testing.T, ipt *IPTables) {
_, subnet2CIDR, _ := net.ParseCIDR(subnet2)

expectedStructStats := []Stat{
{0, 0, "ACCEPT", "all", opt, "*", "*", subnet1CIDR, address1CIDR, ""},
{0, 0, "ACCEPT", "all", opt, "*", "*", subnet2CIDR, address2CIDR, ""},
{0, 0, "ACCEPT", "all", opt, "*", "*", subnet2CIDR, address1CIDR, ""},
{0, 0, "ACCEPT", "all", opt, "*", "*", address1CIDR, subnet2CIDR, ""},
{0, 0, "ACCEPT", prot, opt, "*", "*", subnet1CIDR, address1CIDR, ""},
{0, 0, "ACCEPT", prot, opt, "*", "*", subnet2CIDR, address2CIDR, ""},
{0, 0, "ACCEPT", prot, opt, "*", "*", subnet2CIDR, address1CIDR, ""},
{0, 0, "ACCEPT", prot, opt, "*", "*", address1CIDR, subnet2CIDR, ""},
}

if !reflect.DeepEqual(structStats, expectedStructStats) {
Expand Down

0 comments on commit 1b5df17

Please sign in to comment.