Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Git-based Docker Compose deployment is Broken #3277

Closed
1 of 2 tasks
brandnewx opened this issue Aug 31, 2024 · 7 comments
Closed
1 of 2 tasks

[Bug]: Git-based Docker Compose deployment is Broken #3277

brandnewx opened this issue Aug 31, 2024 · 7 comments

Comments

@brandnewx
Copy link

Description

So today Docker Compose applications from Git are no longer deployable because Coolify or Coolify Helper docker image has this new bug where it generated a malformed .env file during building.

See Deployment logs:

[COMMAND] docker exec xxxxx bash -c 'SOURCE_COMMIT=xxxxx COOLIFY_BRANCH=main docker compose --env-file /artifacts/xxxxx/.env --project-name xxxxx --project-directory /artifacts/xxxxx-f /artifacts/xxxx/docker-compose.yml build --pull'
[OUTPUT]
failed to read /artifacts/xxxxxx/.env: line 4: key cannot contain a space

[2024-Aug-31 06:44:00.474211] Oops something is not okay, are you okay? 😢

[2024-Aug-31 06:44:00.657908] failed to read /artifacts/xxxxx/.env: line 4: key cannot contain a space

Minimal Reproduction (if possible, example repository)

Create new application > Git Repository > Choose Docker Compose. Deploy and you'll see the bug.

Exception or Error

No response

Version

v4.0.0-beta.324

Cloud?

  • Yes
  • No
@brandnewx brandnewx changed the title [Bug]: [Bug]: failed to read /artifacts/xxxxx/.env: line 4: key cannot contain a space Sep 1, 2024
@brandnewx brandnewx changed the title [Bug]: failed to read /artifacts/xxxxx/.env: line 4: key cannot contain a space [Bug]: Git-based Docker Compose deployment is Broken Sep 1, 2024
@vanWittlaer
Copy link

Same here

@peaklabs-dev peaklabs-dev added 🐛 Bug Reported issues that need to be reproduced by the team. 🟠 Medium Priority Issues that should be addressed soon. labels Sep 2, 2024
@nnti3n
Copy link

nnti3n commented Sep 3, 2024

Same here, cant deploy

[2024-Sep-03 09:56:06.921547] Preparing container with helper image: ghcr.io/coollabsio/coolify-helper:latest.
[2024-Sep-03 09:56:09.364622] ----------------------------------------
[2024-Sep-03 09:56:09.369067] Importing *** (commit sha HEAD) to /artifacts/hcc80c840gg08084c4ss4w8o.
[2024-Sep-03 09:56:14.882095] Pulling & building required images.
[2024-Sep-03 09:56:15.311128] Oops something is not okay, are you okay? 😢

[2024-Sep-03 09:56:15.313833] failed to read /artifacts/hcc80c840gg08084c4ss4w8o/.env: line 4: key cannot contain a space

@aschelch
Copy link

aschelch commented Sep 3, 2024

Same here !

Edit: In the meantime, try removing space in your project name (and "/" in your ressource name). On my side, it unblock the situation ;)

@adaichendt-tv1
Copy link

Downgrade to beta 323 for now. You don't need to comment that it affects you too, simply hit the thumbs up button below the initial report.

@peaklabs-dev peaklabs-dev added 🔴 High Priority Issues that require immediate attention. and removed 🟠 Medium Priority Issues that should be addressed soon. labels Sep 3, 2024
@Pokymon
Copy link

Pokymon commented Sep 4, 2024

Same here. Just two hours ago, I got this exact same bug.

@andrasbacsai
Copy link
Member

andrasbacsai commented Sep 4, 2024

This will be fixed in the upcoming version in #3306 , but I would like you to test it as well. I could not reproduce it after the fix.

Edit: It is released. Can you please test?

@peaklabs-dev peaklabs-dev added 💤 Waiting for feedback Issues awaiting a response from the author. and removed 🔴 High Priority Issues that require immediate attention. labels Sep 4, 2024
@pipegalera
Copy link

@andrasbacsai I deployed 1 hour ago after updating and no problem on simple a static site based on a Github repo.

Docker worked without fails, thanks champ!

@peaklabs-dev peaklabs-dev removed 🐛 Bug Reported issues that need to be reproduced by the team. 💤 Waiting for feedback Issues awaiting a response from the author. labels Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants