Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transfers.txt should override BOARD_SLACK_SECONDS and OSM walk distance #641

Open
abyrd opened this issue Oct 28, 2020 · 2 comments
Open
Assignees
Labels
p1 Priority level 1: high, but not the top t1 Time level 1: think days

Comments

@abyrd
Copy link
Member

abyrd commented Oct 28, 2020

At least for the standard stop-to-stop entries in transfers.txt, and especially for the transfer type 2 ("minimum amount of time between arrival and departure to ensure a connection") we should be overriding the default OSM walk distance calculations. Although the GTFS spec text says "minimum amount of time", I believe the proper interpretation is to completely replace any transfers found by walking through the OSM network: transfers.txt is providing a typical safe amount of time needed to walk between the two stops.

This gets a little tricky because we currently apply a hard lower limit of 60 seconds between alighting and boarding, which would have to be configurable and interact with the transfer entries.

Related to #330. Some of these behaviors may need to be configurable at the routing or network building stage, as not all users will want stations and transfers to be interpreted in the same way. Many of these characteristics must be made optional, but we'll need a mechanism to configure that (#644).

@abyrd abyrd self-assigned this Oct 28, 2020
@abyrd abyrd added p1 Priority level 1: high, but not the top t1 Time level 1: think days labels Oct 28, 2020
@abyrd
Copy link
Member Author

abyrd commented Oct 30, 2020

Strangely BOARD_SLACK_SECONDS appears to only be used in classes for displaying paths, not for routing. This should be described in more detail in the docs.

@abyrd
Copy link
Member Author

abyrd commented Feb 2, 2021

Discussed again today - we decided that if transfers.txt is present, especially with transfers of type 2, then overriding any OSM transfers is more correct and should be the default behavior - in fact this probably doesn't even need a switch to disable it unless someone comes up with a concrete need to disable it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1 Priority level 1: high, but not the top t1 Time level 1: think days
Projects
None yet
Development

No branches or pull requests

1 participant