Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WHERE clause into JDBC source connector config #1022

Open
pMan opened this issue Mar 13, 2021 · 5 comments
Open

Add WHERE clause into JDBC source connector config #1022

pMan opened this issue Mar 13, 2021 · 5 comments

Comments

@pMan
Copy link

pMan commented Mar 13, 2021

Hello,

I know how various modes work with a WHERE clause appended to table/query param, but I cannot think of any strong opinion as to why filtering option on some other columns at source is not an option in the config.

I can probably contribute if it makes a good feature.

@pMan
Copy link
Author

pMan commented Apr 12, 2021

query.suffix property can be used to add the where clause.

The auto-generated query adds a WHERE clause as well as an ORDER BY. query.suffix is appended to the generated query after ORDER BY, so query.suffix can't be used for adding WHERE clause. Also, query.suffix is added for a different purpose.

@szalapski
Copy link

FYI, this touches on what you seem to want to do with a different approach: #1041

@pMan
Copy link
Author

pMan commented Apr 22, 2021

FYI, this touches on what you seem to want to do with a different approach: #1041

Thanks szalapski. And I have some code changes that work for me, and created a pull request, too.

@szalapski
Copy link

What PR?

@pMan
Copy link
Author

pMan commented Apr 24, 2021

What PR?

Here is the link - #1030

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants