Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug when using custom conclusion_file on Windows #700

Closed
larsoner opened this issue Jul 13, 2023 · 0 comments · Fixed by #701
Closed

Bug when using custom conclusion_file on Windows #700

larsoner opened this issue Jul 13, 2023 · 0 comments · Fixed by #701
Labels
locked [bot] locked due to inactivity

Comments

@larsoner
Copy link

...I think it's a bug introduced in this release (probably this line). conclusion_file can also be a NSI script, and in that case it gets inlined. I can see locally that RTF contents were dumped directly in the script.

I think the only workaround for now is to disable the custom conclusion file on Windows installers. I'll open a PR on constructor next week.

Originally posted by @jaimergp in mne-tools/mne-installers#195 (comment)
@jaimergp jaimergp mentioned this issue Jul 19, 2023
Merged
3 tasks
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Jul 24, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
locked [bot] locked due to inactivity
Projects
🧭 Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

only insert custom_conclusion if the file ends in .nsi jaimergp/constructor
1 participant
@larsoner