makensis exit code not checked on Windows

[FaustinCarter]

In verbose mode the makensis return code is not properly checked. Any failure of makensis will be treated as a success by constructor. This is because subprocess.Popen.communicate (line 209) does note raise an error for non-zero return codes the same way that subprocess.check_call (line 217) does.

constructor/constructor/winexe.py

Lines 207 to 220 in a7ad3d2

	if verbose:
	sub = Popen(args, stdout=PIPE, stderr=PIPE)
	stdout, stderr = sub.communicate()
	for msg, information in zip((stdout, stderr), ('stdout', 'stderr')):
	# on Python3 we're getting bytes
	if hasattr(msg, 'decode'):
	msg = msg.decode()
	print('makensis {}:'.format(information))
	print(msg)
	else:
	check_call(args)
	shutil.rmtree(tmp_dir)

Suggested fix is to explicitly check sub.returncode and raise an error.