Implemented review feedback for PR #55 #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added 3 new columns to `stations` db table: `evse_country_id`, `evse_operator_id` and `evse_station_id` - moved `lst_expand` method to `shared` 2. Converted all tests to pytest (simpler syntax) and refactored some of them 3. Implemented many fixes in order to eliminate warnings from the static code analyzers
mjmader
reviewed
Dec 8, 2023
mjmader
reviewed
Dec 8, 2023
…ging (s. FIXME in merger.py)
…to 60 seconds, Chasing flaky tests on GH.
Created a GitHub workflow to check data sources for validity daily (currently for DE/BNA only)
mjmader
approved these changes
Dec 21, 2023
There was a problem hiding this comment.
I ran the de and at pipelines, and those looked fine to me with the changes.
The only problem I had was that when i do not set DB_SCHEMA in env, I get
============================================================================================================================================= short test summary info =============================================================================================================================================
ERROR tests/integration/test_int_merger.py::test_int_deduplication_expect_a_merged_entry_if_two_duplicates_exists - sqlalchemy.exc.ProgrammingError: (psycopg2.errors.DuplicateSchema) schema "public" already exists
ERROR tests/integration/test_int_merger.py::test_int_deduplication_ocm_should_have_higher_prio_than_bna - sqlalchemy.exc.ProgrammingError: (psycopg2.errors.DuplicateSchema) schema "public" already exists
ERROR tests/integration/test_int_merger.py::test_int_at_merger_bug_country_code_data_source_mismatch - sqlalchemy.exc.ProgrammingError: (psycopg2.errors.DuplicateSchema) schema "public" already exists
========================================================================================================================================== 99 passed, 3 errors in 31.44s ==========================================================================================================================================
when running pytest. Tests work if I set a DB_SCHEMA value.
I think we can fix this in a later PR
…the `date_created` test case for a 60 seconds difference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stationsdb table:evse_country_id,evse_operator_idandevse_station_idlst_expandmethod toshared