Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #52: Implement mapping of OSM charging values #53

Merged

Conversation

cs-dieter-kling
Copy link
Contributor

No description provided.

@cs-dieter-kling cs-dieter-kling linked an issue Nov 14, 2023 that may be closed by this pull request
@cs-dieter-kling cs-dieter-kling changed the title Feature #52: Implement mapping of OSM charging values [WIP!] Feature #52: Implement mapping of OSM charging values Nov 14, 2023
@cs-dieter-kling cs-dieter-kling marked this pull request as ready for review December 1, 2023 10:16
@cs-dieter-kling cs-dieter-kling changed the title [WIP!] Feature #52: Implement mapping of OSM charging values Feature #52: Implement mapping of OSM charging values Dec 1, 2023
@cs-dieter-kling cs-dieter-kling self-assigned this Dec 1, 2023
@stefanpernpaintner
Copy link
Collaborator

When executing the tests I run in the following errors:

======================================================================
ERROR: test_address_mapping (pipelines.osm.test_osm_mapper.Test)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/pernpas/encrypted/dev/projects/stations-pipelines/test/pipelines/osm/test_osm_mapper.py", line 38, in test_address_mapping
    address: Address = map_address_osm(json_data, 1)
  File "/home/pernpas/encrypted/dev/projects/stations-pipelines/charging_stations_pipelines/pipelines/osm/osm_mapper.py", line 73, in map_address_osm
    map_address.district_old = None
  File "/home/pernpas/encrypted/dev/projects/stations-pipelines/charging_stations_pipelines/models/__init__.py", line 21, in __setattr__
    raise AttributeError(f"Cannot set non-existing attribute '{name}' on class '{self.__class__.__name__}'.")
AttributeError: Cannot set non-existing attribute 'district_old' on class 'Address'.

======================================================================
FAIL: test_charging_mapping__plain_01 (pipelines.osm.test_osm_mapper.Test)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/pernpas/encrypted/dev/projects/stations-pipelines/test/pipelines/osm/test_osm_mapper.py", line 72, in test_charging_mapping__plain_01
    self.assertEqual([2.3], charging.kw_list)
AssertionError: Lists differ: [2.3] != []

First list contains 1 additional elements.
First extra element 0:
2.3

- [2.3]
+ []

Can you please check?

@cs-dieter-kling
Copy link
Contributor Author

Hi @stefanpernpaintner, all problems are fixed now.

@stefanpernpaintner stefanpernpaintner merged commit 6fc0b80 into main Dec 7, 2023
@mjmader mjmader deleted the feature/52-implement-mapping-of-osm-charging-values branch February 22, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement mapping of OSM charging values
5 participants