Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using hashed lat/long for BNA's source_id leads to error #30

Open
stefanpernpaintner opened this issue Jul 10, 2023 · 1 comment · May be fixed by #62
Open

Using hashed lat/long for BNA's source_id leads to error #30

stefanpernpaintner opened this issue Jul 10, 2023 · 1 comment · May be fixed by #62

Comments

@stefanpernpaintner
Copy link
Collaborator

Currently the source_id value for BNA's charging stations is filled with the has value over lat/long. This leads to the situation that some charging stations have the same hash value because they have the same lat/long values set (most likely by error) and this in turn leads to the fact that some stations cannot be imported because of a unique key constraint error (source_id has to be unique)

I think we should generate the hash over all attributes of the BNA's charging station to avoid the described situation
@mjmader mjmader changed the title Using hased lat/long for BNA's source_id leads to error Using hahsed lat/long for BNA's source_id leads to error Jul 11, 2023
@cs-dieter-kling cs-dieter-kling changed the title Using hahsed lat/long for BNA's source_id leads to error Using hashed lat/long for BNA's source_id leads to error Nov 10, 2023
@cs-dieter-kling cs-dieter-kling self-assigned this Dec 1, 2023
@cs-dieter-kling cs-dieter-kling linked a pull request Dec 1, 2023 that will close this issue
[WIP!] BNA station ID collision fix #62
Draft
@mjmader
Copy link
Collaborator

mjmader commented Feb 2, 2024

Actually the problem is that the rows of the BNA data (and also FR data btw) have changed over time to resemble charge points of charging stations, rather than just a charging station per row.
In effect, we have to do some preprocessing to flatten serveral charge points into a single station.
On the other hand, this is also important for #28, maybe it is better to change our schema to actually handle charge points

@mjmader mjmader mentioned this issue Feb 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP!] BNA station ID collision fix comsysto/eCharm
3 participants
@cs-dieter-kling @mjmader @stefanpernpaintner