Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip the :nocov: comments. #551

Merged
merged 1 commit into from
Jan 26, 2017
Merged

Skip the :nocov: comments. #551

merged 1 commit into from
Jan 26, 2017

Conversation

ebiven
Copy link
Contributor

@ebiven ebiven commented Jan 26, 2017

When using the nocov comment token the start and stop tokens are considered lines to be covered. Addresses the following issues:

colszowka#468

colszowka#527

When using the `nocov` comment token the start and stop tokens are considered lines to be covered. Addresses the following issues:

colszowka#468

colszowka#527
@ebiven
Copy link
Contributor Author

ebiven commented Jan 26, 2017

@colszowka : This is a refresh of #531 since the repo had moved for three months.

@PragTob
Copy link
Collaborator

PragTob commented Jan 26, 2017

Looks good, all test changes make sense to me (e.g. from never to skipped).

Thanks a lot!

@PragTob PragTob merged commit 81f6c35 into simplecov-ruby:master Jan 26, 2017
@PragTob PragTob mentioned this pull request Mar 5, 2017
potomak added a commit to potomak/coveralls-ruby that referenced this pull request Mar 19, 2017
Note: simplecov 0.14.0 fixed an issue that was breaking the example at
`spec/coveralls/simplecov_spec.rb:75`.

Before the result of `#get_source_files` for `fixtures/sample.rb` was:

```
00 COUNTED - # Foo class
01 COUNTED - class Foo
02 COUNTED -   def initialize
03 COUNTED -     @foo = 'baz'
04 COUNTED -   end
05 COUNTED -
06 COUNTED -   # :nocov:
07 SKIPPED -   def bar
08 SKIPPED -     @foo
09 SKIPPED -   end
10 COUNTED -   # :nocov:
11 COUNTED - end
```

Using simplecov 0.14.1, that includes
simplecov-ruby/simplecov#551, the result is:

```
00 COUNTED - # Foo class
01 COUNTED - class Foo
02 COUNTED -   def initialize
03 COUNTED -     @foo = 'baz'
04 COUNTED -   end
05 COUNTED -
06 SKIPPED -   # :nocov:
07 SKIPPED -   def bar
08 SKIPPED -     @foo
09 SKIPPED -   end
10 SKIPPED -   # :nocov:
11 COUNTED - end
```
jsonn pushed a commit to jsonn/pkgsrc that referenced this pull request Mar 20, 2017
0.14.1 2017-03-18 ([changes](simplecov-ruby/simplecov@v0.14.0...v0.14.1))
========

## Bugfixes

* Files that were skipped as a whole/had no relevant coverage could lead to Float errors. See [#564](simplecov-ruby/simplecov#564) (thanks to @stevehanson for the report in [#563](simplecov-ruby/simplecov#563))

0.14.0 2017-03-15 ([changes](simplecov-ruby/simplecov@v0.13.0...v0.14.0))
==========

## Enhancements

* Officially support JRuby 9.1+ going forward (should also work with previous releases). See [#547](simplecov-ruby/simplecov#547) (ping @PragTob when encountering issues)
* Add Channel group to Rails profile, when `ActionCable` is loaded. See [#492](simplecov-ruby/simplecov#492) (thanks @BenMorganIO)
* Stop `extend`ing instances of `Array` and `Hash` during merging results avoiding problems frozen results while manually merging results. See [#558](simplecov-ruby/simplecov#558) (thanks @aroben)

## Bugfixes

* Fix parallel_tests when a thread ends up running no tests. See [#533](simplecov-ruby/simplecov#533) (thanks @cshaffer)
* Skip the `:nocov:` comments along with the code that they skip. See [#551](simplecov-ruby/simplecov#551) (thanks @ebiven)
* Fix crash when Home environment variable is unset. See [#482](simplecov-ruby/simplecov#482) (thanks @waldyr)
* Make track_files work again when explicitly setting it to nil. See [#463](simplecov-ruby/simplecov#463) (thanks @craiglittle)
* Do not overwrite .last_run.json file when refuse_coverage_drop option is enabled and the coverage has dropped (lead to you being able to just rerun tests and everything was _fine_). See [#553](simplecov-ruby/simplecov#553) (thanks @Miloshes)

0.13.0 2016-01-25 ([changes](simplecov-ruby/simplecov@v0.12.0...v0.13.0))
==========

## Enhancements

* Faster run times when a very large number of files is loaded into SimpleCov. See [#520](simplecov-ruby/simplecov#520) (thanks @alyssais)
* Only read in source code files that are actually used (faster when files are ignored etc.). See [#540](simplecov-ruby/simplecov#540) (tahks @yui-knk)

## Bugfixes

* Fix merging of resultsets if a file is missing on one side. See [#513](simplecov-ruby/simplecov#513) (thanks @hanazuki)
* Fix Ruby 2.4 deprecation warnings by using Integer instead of Fixnum. See [#523](simplecov-ruby/simplecov#523) (thanks @nobu)
* Force Ruby 2 to json 2. See [dc7417d50](simplecov-ruby/simplecov@dc7417d) (thanks @amatsuda)
* Various other gem dependency fixes for different gems on different ruby versions. (thanks @amatsuda)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants