-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide confusing warning message from setuptools #140
Comments
@AAlon this is related to setuptool and not to colcon-bundle. Looking into it a bit though, I see that specifying
to |
re: not related to colcon-bundle - setuptools might not be a dependency of the customer's application. It's a dependency of pip, which is a dependency of colcon-bundle. So when customers bundle their ROS1 application, even if it has no use of setuptools - it will be bundled with Python2.x + setuptools (with the version that colcon-bundle decided). The customer has no control over that, which is why I thought that exploring a solution on colcon-bundle's side is worth looking into. Colcon-bundle could do something (rather ugly) like patch the warning message string of the setuptools installation in the bundle to be empty, or be less scary ;) Or, patch the default warning config to filter out that particular warning. Hopefully there are more elegant solutions out there. |
I wasn't able to reproduce locally and I don't think it's wise to suppress warnings. I think the solution is to release colcon-bundle 0.0.19 with the latest changes which pin the setuptools version (As suggested by the official docs). |
As a result of #127 an incompatible version of setuptools will not be installed. We need a way to hide the irrelevant warning:
Not sure the solution would be in colcon-bundle but perhaps it's possible for colcon-bundle to change the warning configuration when it prepares the bundle with setuptools.
Refer to internal issue B9SIM-1008.
The text was updated successfully, but these errors were encountered: