feat(alpha): monitoring tasks api #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #921 +/- ##
==========================================
- Coverage 84.06% 79.24% -4.83%
==========================================
Files 70 106 +36
Lines 1952 3426 +1474
Branches 249 440 +191
==========================================
+ Hits 1641 2715 +1074
- Misses 301 709 +408
+ Partials 10 2 -8
|
VerstraeteBert
approved these changes
Nov 25, 2022
| externalId: channelExternalId, | ||
| }, | ||
| ]); | ||
| expect(response).toEqual({}); |
There was a problem hiding this comment.
Check for status 200?
There was a problem hiding this comment.
Check for status 200?
we technically don't have access to the status at this level anymore (at least the easy way), if 400+ status happens it will throw an error at earlier stages
Co-authored-by: Bert Verstraete <bertverstraete22@gmail.com>
tengelskar
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds monitoring task api to the alpha client
NOTE: Geospatial tests are failing these days, spoke to @saagar-cognite we agreed to disable them until the backend stabilizes.