-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): remove slash suffix from uris [release] #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersfylling
changed the title
fix(core): remove trailing suffix from urls
fix(core): remove trailing suffix from urls [release]
Aug 3, 2021
andersfylling
requested review from
bdimitrijoski,
jarlah,
peternic,
polomani and
a team
as code owners
August 3, 2021 11:09
Codecov Report
@@ Coverage Diff @@
## master #628 +/- ##
==========================================
- Coverage 77.15% 75.63% -1.52%
==========================================
Files 87 90 +3
Lines 2779 3185 +406
Branches 390 440 +50
==========================================
+ Hits 2144 2409 +265
- Misses 599 776 +177
+ Partials 36 0 -36
|
andersfylling
changed the title
fix(core): remove trailing suffix from urls [release]
fix(core): remove slash suffix from uris [release]
Aug 3, 2021
To make a more unbiased argument; The RFC states that uri/path segments are to be separated by slashes. Given that get parameters aren't a segment, there should not be a slash after the path, separating the path and get parameters. |
tommythorsen
approved these changes
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the requests urls ends with
/
. This becomes a problem when using GET parameters:https://api.cognitedata.com/api/playground/projects/cognitesdk-js/documents/feedback/?status=CREATED
While
/documents/feedback/?status=CREATED
responds with a 404,/documents/feedback?status=CREATED
responds with an expected 200 status code.