feat(core): don't check if its https if its not a browser #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #524 +/- ##
=======================================
Coverage 79.23% 79.23%
=======================================
Files 82 82
Lines 2605 2605
Branches 377 377
=======================================
Hits 2064 2064
Misses 524 524
Partials 17 17
|
jarlah
force-pushed
the
fixForServerApplications
branch
from
cdecad8
to
c236d17
Compare
|
you have to add |
jarlah
changed the title
jarlah
changed the title
jarlah
changed the title
jarlah
changed the title
jarlah
force-pushed
the
fixForServerApplications
branch
from
c236d17
to
d988e7f
Compare
vegardok
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In air-api in application-services I have thousand of thousands of requests that push "You should use SSL (https) when you login with OAuth since CDF only allows redirecting back to an HTTPS site" to the error logs in Stackdriver in production. It's pretty much a useless warning (that sadly is picked up with severity ERROR by Stackdriver). But the problem is, why should it be there? When there is no browser? So, the isBrowser was added to avoid "null pointer exceptions". This change is making sure its never called unless its a browser. specifically where it tries to log the statement above.
I assume the function isUsingSSL is used other places, so I don't touch it.