fix: fileAPI upload endpoint #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #427 +/- ##
==========================================
+ Coverage 88.76% 88.93% +0.16%
==========================================
Files 63 63
Lines 1727 1726 -1
Branches 220 220
==========================================
+ Hits 1533 1535 +2
+ Misses 184 181 -3
Partials 10 10
|
hhenriques
approved these changes
Sep 17, 2020
maksnester
reviewed
Nov 17, 2020
| @@ -51,7 +50,8 @@ export function convertToTimestampToDateTime(timestamp: number): Date { | |||
| export function isJson(data: any) { | |||
| return ( | |||
| (isArray(data) || isObject(data)) && | |||
| !isBuffer(data) && | |||
| !Buffer.isBuffer(data) && | |||
There was a problem hiding this comment.
Passes the test (runs in node) but crashes in a browser because there is no global Buffer in browsers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
uploadendpoint ofFilesAPIby preventing content-type header changes based onisJsoncheck of the request body.Previously,
isJsonreturnstrueforArrayBufferrequest body type and setcontent-type: application/jsonheader instead of provided content-type header in params.[release]