Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: monitoring tasks upsert #1042

Merged
merged 5 commits into from
Nov 28, 2023
Merged

feat: monitoring tasks upsert #1042

merged 5 commits into from
Nov 28, 2023

Conversation

23andreas
Copy link
Contributor

@23andreas 23andreas commented Nov 27, 2023 •
edited
Loading

  • Adds monitoring tasks upsert - docs
  • Updates MonitoringTaskCreate interface, make interval and overlap optional to match api

These changes are primarily in the beta package, but I have added a new endpoint to core and a new type to stable

tuanng-cognite
tuanng-cognite approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@tuanng-cognite tuanng-cognite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Assuming that most stuffs are generated.

@23andreas
Copy link
Contributor Author

LGTM, Assuming that most stuffs are generated.

generated? Is there a way to generate types etc from the api?

@tuanng-cognite
Copy link
Contributor

LGTM, Assuming that most stuffs are generated.

generated? Is there a way to generate types etc from the api?

I mixed it with other sdk. There are no tools to generate SDK code for this. Sorry

@23andreas 23andreas marked this pull request as ready for review November 27, 2023 15:27
nabati
nabati reviewed Nov 28, 2023
View reviewed changes
Copy link
Contributor

@nabati nabati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but difficult for me to assess in isolation

packages/beta/src/__tests__/api/monitoringTasksApi.int.spec.ts Show resolved Hide resolved
@23andreas 23andreas merged commit 7e0e24c into master Nov 28, 2023
10 checks passed
@23andreas 23andreas deleted the feat-beta-add-monitoring-upsert branch November 28, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabati nabati nabati left review comments

@polomani polomani polomani left review comments

@saagar-cognite saagar-cognite saagar-cognite left review comments

@tuanng-cognite tuanng-cognite tuanng-cognite approved these changes

@BugGambit BugGambit Awaiting requested review from BugGambit BugGambit is a code owner

@andersfylling andersfylling Awaiting requested review from andersfylling

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@23andreas @tuanng-cognite @nabati @polomani @saagar-cognite