feat(alpha): simulator integration API #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polomani
changed the title
polomani
reviewed
Nov 9, 2023
polomani
reviewed
Nov 9, 2023
polomani
reviewed
Nov 9, 2023
polomani
reviewed
Nov 9, 2023
Comment on lines
53
to
55
| public deleteIntegrations = async (ids: IdEither[]) => { | ||
| return this.integrationsApi.delete(ids); | ||
| }; |
There was a problem hiding this comment.
don't think we have delete integrations (yet), are you suggesting on making it future proof? :)
polomani
reviewed
Nov 9, 2023
polomani
reviewed
Nov 9, 2023
packages/beta/src/types.ts
Outdated
Comment on lines
434
to
436
| export interface SimulatorResourceChange | ||
| extends SimulatorResourcePatch, | ||
| InternalId { } |
There was a problem hiding this comment.
Suggested change
| export interface SimulatorResourceChange | |
| extends SimulatorResourcePatch, | |
| InternalId { } | |
| export interface SimulatorChangeById extends SimulatorPatch, InternalId {} | |
| export interface SimulatorChange = SimulatorChangeById; |
Let's make it two step, in case we need to extend with SimulatorChangeByExternalId (easily)
polomani
reviewed
Nov 9, 2023
polomani
reviewed
Nov 9, 2023
packages/beta/src/cogniteClient.ts
Outdated
| @@ -55,6 +61,7 @@ export default class CogniteClient extends CogniteClientCleaned { | |||
|
|
|||
| this.httpClient.setDefaultHeader('cdf-version', 'beta'); | |||
|
|
|||
| this.simulatorsApi = this.apiFactory(SimulatorsAPI, 'simulators'); | |||
There was a problem hiding this comment.
You are right, it's alpha, we'll move it to alpha for now.
…dk-js into onboard-simint-api
polomani
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.