feat(alpha): monitoring task add source and sourceId props - [AH-1863] #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absqueued
requested review from
BugGambit,
andersfylling and
a team
as code owners
andersfylling
approved these changes
Sep 20, 2023
polomani
reviewed
Sep 20, 2023
guides/auth-wrapper.md
Outdated
| @@ -441,4 +441,4 @@ await client.authenticate(); // Returns the received token | |||
| | |||
| ## Next steps | |||
| | |||
| To read more about authentication, see [authentication process](https://doc.cognitedata.com/dev/guides/iam/external-application.html#tokens). | |||
| To read more about authentication, see [authentication process](https://developer.cognite.com/dev/guides/iam/external-application.html#tokens). | |||
There was a problem hiding this comment.
Suggested change
| To read more about authentication, see [authentication process](https://developer.cognite.com/dev/guides/iam/external-application.html#tokens). | |
| To read more about authentication, see [authentication process](https://developer.cognite.com/dev/guides/iam/external-application#tokens). |
polomani
reviewed
Sep 20, 2023
guides/authentication.md
Outdated
| @@ -181,4 +181,4 @@ const client = new CogniteClient({ | |||
|
|
|||
| ## More | |||
|
|
|||
| Read more about the [authentication process](https://doc.cognitedata.com/dev/guides/iam/external-application.html#tokens). | |||
| Read more about the [authentication process](https://developer.cognite.com/dev/guides/iam/external-application.html#tokens). | |||
There was a problem hiding this comment.
Suggested change
| Read more about the [authentication process](https://developer.cognite.com/dev/guides/iam/external-application.html#tokens). | |
| Read more about the [authentication process](https://developer.cognite.com/dev/guides/iam/external-application#tokens). |
polomani
reviewed
Sep 20, 2023
packages/stable/CHANGELOG.md
Outdated
| @@ -695,7 +695,7 @@ Co-authored-by: Vegard Økland <vegard.okland@cognite.com> | |||
| - TimeseriesClass | |||
| - TimeSeriesList | |||
|
|
|||
| For replacements, see [MIGRATION_GUIDE_2xx_3xx.md](https://docs.cognite.com/dev/guides/sdk/js/migration.html#upgrade-javascript-sdk-2-x-to-3-x) | |||
| For replacements, see [MIGRATION_GUIDE_2xx_3xx.md](https://docs.cognite.com/dev/guides/sdk/js/migration.html#upgrade-javascript-sdk-2x-to-3x) | |||
There was a problem hiding this comment.
Suggested change
| For replacements, see [MIGRATION_GUIDE_2xx_3xx.md](https://docs.cognite.com/dev/guides/sdk/js/migration.html#upgrade-javascript-sdk-2x-to-3x) | |
| For replacements, see [MIGRATION_GUIDE_2xx_3xx.md](https://docs.cognite.com/dev/guides/sdk/js/migration#upgrade-javascript-sdk-2x-to-3x) |
polomani
reviewed
Sep 20, 2023
saagar-cognite
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating type of monitoring task to accept
sourceandsourceIdoptional props.Bonus: