Support for storage variables #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![bridgecrew[bot]](https://avatars.githubusercontent.com/in/52968?s=60&v=4){kind=small}
There was a problem hiding this comment.
Change details
-
Error ID Change Path Resource BC_AWS_IAM_66 Fixed /main.tf module.rds_cluster.aws_rds_cluster.primary BC_AWS_IAM_66 Fixed /main.tf module.rds_cluster_aurora_mysql_serverless.aws_rds_cluster.primary BC_AWS_IAM_66 Fixed /main.tf module.rds_cluster_aurora_mysql.aws_rds_cluster.primary BC_AWS_GENERAL_38 Fixed /main.tf module.rds_cluster_aurora_postgres.aws_rds_cluster.primary BC_AWS_IAM_66 Fixed /main.tf module.rds_cluster_aurora_postgres.aws_rds_cluster.primary BC_AWS_GENERAL_69 Fixed /main.tf module.rds_cluster_aurora_postgres.aws_rds_cluster.primary BC_AWS_IAM_59 Fixed /main.tf module.rds_cluster_aurora_postgres.aws_rds_cluster.primary BC_AWS_GENERAL_38 Fixed /main.tf module.rds_cluster.aws_rds_cluster.primary BC_AWS_IAM_59 Fixed /main.tf module.rds_cluster.aws_rds_cluster.primary BC_AWS_GENERAL_69 Fixed /main.tf module.rds_cluster_aurora_mysql_serverless.aws_rds_cluster.primary BC_AWS_IAM_59 Fixed /main.tf module.rds_cluster_aurora_mysql_serverless.aws_rds_cluster.primary BC_AWS_GENERAL_38 Fixed /main.tf module.rds_cluster_aurora_mysql.aws_rds_cluster.primary BC_AWS_GENERAL_69 Fixed /main.tf module.rds_cluster_aurora_mysql.aws_rds_cluster.primary BC_AWS_IAM_59 Fixed /main.tf module.rds_cluster_aurora_mysql.aws_rds_cluster.primary
nitrocode
reviewed
Jun 3, 2022
nitrocode
reviewed
Jun 3, 2022
| @@ -70,6 +70,9 @@ resource "aws_rds_cluster" "primary" { | |||
| skip_final_snapshot = var.skip_final_snapshot | |||
| apply_immediately = var.apply_immediately | |||
| storage_encrypted = local.is_serverless ? null : var.storage_encrypted | |||
| storage_type = var.storage_type | |||
There was a problem hiding this comment.
Ensure Amazon RDS clusters and instances have AWS IAM authentication enabled
Resource: aws_rds_cluster.primary | ID: BC_AWS_IAM_59
How to Fix
resource "aws_rds_cluster" "default" {
cluster_identifier = "aurora-cluster-demo"
...
+ iam_database_authentication_enabled = true
}Description
TBA. Identity and Access Management (IAM)
| @@ -70,6 +70,9 @@ resource "aws_rds_cluster" "primary" { | |||
| skip_final_snapshot = var.skip_final_snapshot | |||
| apply_immediately = var.apply_immediately | |||
| storage_encrypted = local.is_serverless ? null : var.storage_encrypted | |||
| storage_type = var.storage_type | |||
There was a problem hiding this comment.
Ensure RDS cluster has IAM authentication enabled
Resource: aws_rds_cluster.primary | ID: BC_AWS_IAM_66
Error in referred variable: variable "iam_database_authentication_enabled"
How to Fix
resource "aws_rds_cluster" "enabled" {
...
+ iam_database_authentication_enabled = true
}Description
TBD
There was a problem hiding this comment.
Change details
-
Error ID Change Path Resource BC_AWS_GENERAL_96 Added /main.tf aws_rds_cluster.primary BC_AWS_GENERAL_49 Added /main.tf aws_rds_cluster.primary BC_AWS_GENERAL_38 Added /main.tf aws_rds_cluster.primary BC_AWS_IAM_66 Added /main.tf aws_rds_cluster.primary BC_AWS_GENERAL_69 Added /main.tf aws_rds_cluster.primary BC_AWS_IAM_59 Added /main.tf aws_rds_cluster.primary
| @@ -70,6 +70,9 @@ resource "aws_rds_cluster" "primary" { | |||
| skip_final_snapshot = var.skip_final_snapshot | |||
| apply_immediately = var.apply_immediately | |||
| storage_encrypted = local.is_serverless ? null : var.storage_encrypted | |||
| storage_type = var.storage_type | |||
There was a problem hiding this comment.
Ensure RDS cluster has IAM authentication enabled
Resource: module.rds_cluster.aws_rds_cluster.primary | ID: BC_AWS_IAM_66
How to Fix
resource "aws_rds_cluster" "enabled" {
...
+ iam_database_authentication_enabled = true
}Description
TBD🎉 Fixed by commit e789db1 - Merge branch 'master' into master
| @@ -70,6 +70,9 @@ resource "aws_rds_cluster" "primary" { | |||
| skip_final_snapshot = var.skip_final_snapshot | |||
| apply_immediately = var.apply_immediately | |||
| storage_encrypted = local.is_serverless ? null : var.storage_encrypted | |||
| storage_type = var.storage_type | |||
There was a problem hiding this comment.
Ensure Amazon RDS clusters and instances have AWS IAM authentication enabled
Resource: module.rds_cluster.aws_rds_cluster.primary | ID: BC_AWS_IAM_59
How to Fix
resource "aws_rds_cluster" "default" {
cluster_identifier = "aurora-cluster-demo"
...
+ iam_database_authentication_enabled = true
}Description
TBA. Identity and Access Management (IAM)🎉 Fixed by commit e789db1 - Merge branch 'master' into master
| @@ -70,6 +70,9 @@ resource "aws_rds_cluster" "primary" { | |||
| skip_final_snapshot = var.skip_final_snapshot | |||
| apply_immediately = var.apply_immediately | |||
| storage_encrypted = local.is_serverless ? null : var.storage_encrypted | |||
| storage_type = var.storage_type | |||
There was a problem hiding this comment.
Ensure Amazon RDS clusters and instances have AWS IAM authentication enabled
Resource: module.rds_cluster_aurora_serverlessv2_postgres_13.aws_rds_cluster.primary | ID: BC_AWS_IAM_59
How to Fix
resource "aws_rds_cluster" "default" {
cluster_identifier = "aurora-cluster-demo"
...
+ iam_database_authentication_enabled = true
}Description
TBA. Identity and Access Management (IAM)🎉 Fixed by commit e789db1 - Merge branch 'master' into master
| @@ -70,6 +70,9 @@ resource "aws_rds_cluster" "primary" { | |||
| skip_final_snapshot = var.skip_final_snapshot | |||
| apply_immediately = var.apply_immediately | |||
| storage_encrypted = local.is_serverless ? null : var.storage_encrypted | |||
| storage_type = var.storage_type | |||
There was a problem hiding this comment.
Ensure Amazon RDS clusters and instances have AWS IAM authentication enabled
Resource: module.rds_cluster_aurora_mysql_serverless.aws_rds_cluster.primary | ID: BC_AWS_IAM_59
How to Fix
resource "aws_rds_cluster" "default" {
cluster_identifier = "aurora-cluster-demo"
...
+ iam_database_authentication_enabled = true
}Description
TBA. Identity and Access Management (IAM)🎉 Fixed by commit e789db1 - Merge branch 'master' into master
| @@ -70,6 +70,9 @@ resource "aws_rds_cluster" "primary" { | |||
| skip_final_snapshot = var.skip_final_snapshot | |||
| apply_immediately = var.apply_immediately | |||
| storage_encrypted = local.is_serverless ? null : var.storage_encrypted | |||
| storage_type = var.storage_type | |||
There was a problem hiding this comment.
Ensure RDS cluster has IAM authentication enabled
Resource: module.rds_cluster_aurora_mysql_serverless.aws_rds_cluster.primary | ID: BC_AWS_IAM_66
How to Fix
resource "aws_rds_cluster" "enabled" {
...
+ iam_database_authentication_enabled = true
}Description
TBD🎉 Fixed by commit e789db1 - Merge branch 'master' into master
| @@ -70,6 +70,9 @@ resource "aws_rds_cluster" "primary" { | |||
| skip_final_snapshot = var.skip_final_snapshot | |||
| apply_immediately = var.apply_immediately | |||
| storage_encrypted = local.is_serverless ? null : var.storage_encrypted | |||
| storage_type = var.storage_type | |||
There was a problem hiding this comment.
Ensure RDS clusters and instances have deletion protection enabled
Resource: module.rds_cluster_aurora_mysql_serverless.aws_rds_cluster.primary | ID: BC_AWS_GENERAL_69
How to Fix
resource "aws_rds_cluster" "default" {
...
+ deletion_protection = true
}Description
TBA🎉 Fixed by commit e789db1 - Merge branch 'master' into master
| @@ -70,6 +70,9 @@ resource "aws_rds_cluster" "primary" { | |||
| skip_final_snapshot = var.skip_final_snapshot | |||
| apply_immediately = var.apply_immediately | |||
| storage_encrypted = local.is_serverless ? null : var.storage_encrypted | |||
| storage_type = var.storage_type | |||
There was a problem hiding this comment.
Ensure RDS cluster has IAM authentication enabled
Resource: module.rds_cluster_aurora_postgres.aws_rds_cluster.primary | ID: BC_AWS_IAM_66
How to Fix
resource "aws_rds_cluster" "enabled" {
...
+ iam_database_authentication_enabled = true
}Description
TBD🎉 Fixed by commit e789db1 - Merge branch 'master' into master
| @@ -70,6 +70,9 @@ resource "aws_rds_cluster" "primary" { | |||
| skip_final_snapshot = var.skip_final_snapshot | |||
| apply_immediately = var.apply_immediately | |||
| storage_encrypted = local.is_serverless ? null : var.storage_encrypted | |||
| storage_type = var.storage_type | |||
There was a problem hiding this comment.
Ensure Amazon RDS clusters and instances have AWS IAM authentication enabled
Resource: module.rds_cluster_aurora_postgres.aws_rds_cluster.primary | ID: BC_AWS_IAM_59
How to Fix
resource "aws_rds_cluster" "default" {
cluster_identifier = "aurora-cluster-demo"
...
+ iam_database_authentication_enabled = true
}Description
TBA. Identity and Access Management (IAM)🎉 Fixed by commit e789db1 - Merge branch 'master' into master
| @@ -70,6 +70,9 @@ resource "aws_rds_cluster" "primary" { | |||
| skip_final_snapshot = var.skip_final_snapshot | |||
| apply_immediately = var.apply_immediately | |||
| storage_encrypted = local.is_serverless ? null : var.storage_encrypted | |||
| storage_type = var.storage_type | |||
There was a problem hiding this comment.
Ensure all data stored in Aurora is securely encrypted at rest
Resource: module.rds_cluster_aurora_postgres.aws_rds_cluster.primary | ID: BC_AWS_GENERAL_38
How to Fix
resource "aws_rds_cluster" "example" {
...
cluster_identifier = "aurora-cluster-demo"
+ storage_encrypted = true
...
}Description
This policy examines the resource **aws_rds_cluster** to check that encryption is set up. The property **storage_encrypted** is examined.🎉 Fixed by commit e789db1 - Merge branch 'master' into master
| @@ -70,6 +70,9 @@ resource "aws_rds_cluster" "primary" { | |||
| skip_final_snapshot = var.skip_final_snapshot | |||
| apply_immediately = var.apply_immediately | |||
| storage_encrypted = local.is_serverless ? null : var.storage_encrypted | |||
| storage_type = var.storage_type | |||
There was a problem hiding this comment.
Ensure RDS clusters and instances have deletion protection enabled
Resource: module.rds_cluster_aurora_mysql.aws_rds_cluster.primary | ID: BC_AWS_GENERAL_69
How to Fix
resource "aws_rds_cluster" "default" {
...
+ deletion_protection = true
}Description
TBA🎉 Fixed by commit e789db1 - Merge branch 'master' into master
| @@ -70,6 +70,9 @@ resource "aws_rds_cluster" "primary" { | |||
| skip_final_snapshot = var.skip_final_snapshot | |||
| apply_immediately = var.apply_immediately | |||
| storage_encrypted = local.is_serverless ? null : var.storage_encrypted | |||
| storage_type = var.storage_type | |||
There was a problem hiding this comment.
Ensure all data stored in Aurora is securely encrypted at rest
Resource: module.rds_cluster.aws_rds_cluster.primary | ID: BC_AWS_GENERAL_38
How to Fix
resource "aws_rds_cluster" "example" {
...
cluster_identifier = "aurora-cluster-demo"
+ storage_encrypted = true
...
}Description
This policy examines the resource **aws_rds_cluster** to check that encryption is set up. The property **storage_encrypted** is examined.🎉 Fixed by commit e789db1 - Merge branch 'master' into master
| @@ -70,6 +70,9 @@ resource "aws_rds_cluster" "primary" { | |||
| skip_final_snapshot = var.skip_final_snapshot | |||
| apply_immediately = var.apply_immediately | |||
| storage_encrypted = local.is_serverless ? null : var.storage_encrypted | |||
| storage_type = var.storage_type | |||
There was a problem hiding this comment.
Ensure all data stored in Aurora is securely encrypted at rest
Resource: module.rds_cluster_aurora_mysql.aws_rds_cluster.primary | ID: BC_AWS_GENERAL_38
How to Fix
resource "aws_rds_cluster" "example" {
...
cluster_identifier = "aurora-cluster-demo"
+ storage_encrypted = true
...
}Description
This policy examines the resource **aws_rds_cluster** to check that encryption is set up. The property **storage_encrypted** is examined.🎉 Fixed by commit e789db1 - Merge branch 'master' into master
| @@ -70,6 +70,9 @@ resource "aws_rds_cluster" "primary" { | |||
| skip_final_snapshot = var.skip_final_snapshot | |||
| apply_immediately = var.apply_immediately | |||
| storage_encrypted = local.is_serverless ? null : var.storage_encrypted | |||
| storage_type = var.storage_type | |||
There was a problem hiding this comment.
Ensure RDS clusters and instances have deletion protection enabled
Resource: module.rds_cluster_aurora_postgres.aws_rds_cluster.primary | ID: BC_AWS_GENERAL_69
How to Fix
resource "aws_rds_cluster" "default" {
...
+ deletion_protection = true
}Description
TBA🎉 Fixed by commit e789db1 - Merge branch 'master' into master
| @@ -70,6 +70,9 @@ resource "aws_rds_cluster" "primary" { | |||
| skip_final_snapshot = var.skip_final_snapshot | |||
| apply_immediately = var.apply_immediately | |||
| storage_encrypted = local.is_serverless ? null : var.storage_encrypted | |||
| storage_type = var.storage_type | |||
There was a problem hiding this comment.
Ensure RDS cluster has IAM authentication enabled
Resource: module.rds_cluster_aurora_serverlessv2_postgres_13.aws_rds_cluster.primary | ID: BC_AWS_IAM_66
How to Fix
resource "aws_rds_cluster" "enabled" {
...
+ iam_database_authentication_enabled = true
}Description
TBD🎉 Fixed by commit e789db1 - Merge branch 'master' into master
| @@ -70,6 +70,9 @@ resource "aws_rds_cluster" "primary" { | |||
| skip_final_snapshot = var.skip_final_snapshot | |||
| apply_immediately = var.apply_immediately | |||
| storage_encrypted = local.is_serverless ? null : var.storage_encrypted | |||
| storage_type = var.storage_type | |||
There was a problem hiding this comment.
Ensure Amazon RDS clusters and instances have AWS IAM authentication enabled
Resource: module.rds_cluster_aurora_mysql.aws_rds_cluster.primary | ID: BC_AWS_IAM_59
How to Fix
resource "aws_rds_cluster" "default" {
cluster_identifier = "aurora-cluster-demo"
...
+ iam_database_authentication_enabled = true
}Description
TBA. Identity and Access Management (IAM)🎉 Fixed by commit e789db1 - Merge branch 'master' into master
| @@ -70,6 +70,9 @@ resource "aws_rds_cluster" "primary" { | |||
| skip_final_snapshot = var.skip_final_snapshot | |||
| apply_immediately = var.apply_immediately | |||
| storage_encrypted = local.is_serverless ? null : var.storage_encrypted | |||
| storage_type = var.storage_type | |||
There was a problem hiding this comment.
Ensure RDS cluster has IAM authentication enabled
Resource: module.rds_cluster_aurora_mysql.aws_rds_cluster.primary | ID: BC_AWS_IAM_66
How to Fix
resource "aws_rds_cluster" "enabled" {
...
+ iam_database_authentication_enabled = true
}Description
TBD🎉 Fixed by commit e789db1 - Merge branch 'master' into master
| @@ -70,6 +70,9 @@ resource "aws_rds_cluster" "primary" { | |||
| skip_final_snapshot = var.skip_final_snapshot | |||
| apply_immediately = var.apply_immediately | |||
| storage_encrypted = local.is_serverless ? null : var.storage_encrypted | |||
| storage_type = var.storage_type | |||
There was a problem hiding this comment.
Ensure all data stored in Aurora is securely encrypted at rest
Resource: module.rds_cluster_aurora_serverlessv2_postgres_13.aws_rds_cluster.primary | ID: BC_AWS_GENERAL_38
How to Fix
resource "aws_rds_cluster" "example" {
...
cluster_identifier = "aurora-cluster-demo"
+ storage_encrypted = true
...
}Description
This policy examines the resource **aws_rds_cluster** to check that encryption is set up. The property **storage_encrypted** is examined.🎉 Fixed by commit e789db1 - Merge branch 'master' into master
|
/test all |
|
@nitrocode terratest passes now, however the failing |
|
cc: @Nuru test/bats are failing. Is this OK to merge as part of the terraform module 1.0.0 release ? |
|
This pull request is now in conflict. Could you fix it @matharoo? 🙏 |
There was a problem hiding this comment.
Change details
-
Error ID Change Path Resource BC_AWS_IAM_59 Fixed /main.tf module.rds_cluster_aurora_postgres.aws_rds_cluster.primary BC_AWS_IAM_59 Fixed /main.tf module.rds_cluster.aws_rds_cluster.primary BC_AWS_GENERAL_38 Fixed /main.tf module.rds_cluster_aurora_postgres.aws_rds_cluster.primary BC_AWS_IAM_66 Fixed /main.tf module.rds_cluster.aws_rds_cluster.primary BC_AWS_IAM_66 Fixed /main.tf module.rds_cluster_aurora_mysql_serverless.aws_rds_cluster.primary BC_AWS_GENERAL_69 Fixed /main.tf module.rds_cluster_aurora_mysql_serverless.aws_rds_cluster.primary BC_AWS_IAM_59 Fixed /main.tf module.rds_cluster_aurora_mysql_serverless.aws_rds_cluster.primary BC_AWS_IAM_66 Fixed /main.tf module.rds_cluster_aurora_postgres.aws_rds_cluster.primary BC_AWS_GENERAL_69 Fixed /main.tf module.rds_cluster_aurora_postgres.aws_rds_cluster.primary BC_AWS_GENERAL_38 Fixed /main.tf module.rds_cluster.aws_rds_cluster.primary BC_AWS_IAM_59 Fixed /main.tf module.rds_cluster_aurora_serverlessv2_postgres_13.aws_rds_cluster.primary BC_AWS_IAM_66 Fixed /main.tf module.rds_cluster_aurora_mysql.aws_rds_cluster.primary BC_AWS_GENERAL_69 Fixed /main.tf module.rds_cluster_aurora_mysql.aws_rds_cluster.primary BC_AWS_IAM_59 Fixed /main.tf module.rds_cluster_aurora_mysql.aws_rds_cluster.primary BC_AWS_GENERAL_38 Fixed /main.tf module.rds_cluster_aurora_mysql.aws_rds_cluster.primary BC_AWS_GENERAL_38 Fixed /main.tf module.rds_cluster_aurora_serverlessv2_postgres_13.aws_rds_cluster.primary BC_AWS_IAM_66 Fixed /main.tf module.rds_cluster_aurora_serverlessv2_postgres_13.aws_rds_cluster.primary
|
/test all |
nitrocode
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
storage_type,iopsandallocated_storage.why
references
aws_rds_cluster