Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional inputs #124

Merged
merged 7 commits into from
Nov 19, 2021
Merged

Additional inputs #124

merged 7 commits into from
Nov 19, 2021

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Nov 18, 2021

what

  • Add performance_insights_retention_period
  • Add ca_cert_identifier
  • Add preferred_maintenance_window to instances
  • Add timeout to instances

why

  • Performance insights retention
  • Add a ca cert identifier
  • Put the maintenance window on cluster and instances
  • Allow rds instances to be created without hitting a timeout

Copy link

@bridgecrew bridgecrew bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bridgecrew has found infrastructure configuration errors in this PR ⬇️

main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
Copy link

@bridgecrew bridgecrew bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️   Due to 526af47 - Add reader/writer info to README - 13 new errors were added

Change details

Error ID Change Path Resource
BC_AWS_LOGGING_28 Added /main.tf aws_rds_cluster_instance.default
BC_AWS_IAM_59 Added /main.tf aws_rds_cluster.secondary
BC_AWS_GENERAL_69 Added /main.tf aws_rds_cluster.secondary
BC_AWS_IAM_66 Added /main.tf aws_rds_cluster.secondary
BC_AWS_GENERAL_38 Added /main.tf aws_rds_cluster.secondary
BC_AWS_IAM_59 Added /main.tf aws_rds_cluster.primary
BC_AWS_GENERAL_69 Added /main.tf aws_rds_cluster.primary
BC_AWS_IAM_66 Added /main.tf aws_rds_cluster.primary
BC_AWS_GENERAL_38 Added /main.tf aws_rds_cluster.primary
BC_AWS_GENERAL_96 Added /main.tf aws_rds_cluster.secondary
BC_AWS_GENERAL_96 Added /main.tf aws_rds_cluster.primary
BC_AWS_GENERAL_49 Added /main.tf aws_rds_cluster.secondary
BC_AWS_GENERAL_49 Added /main.tf aws_rds_cluster.primary

main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
Copy link

@bridgecrew bridgecrew bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️   Due to 0b7b27b - Update main.tf - 13 new errors were added

Change details

Error ID Change Path Resource
BC_AWS_LOGGING_28 Added /main.tf aws_rds_cluster_instance.default
BC_AWS_IAM_59 Added /main.tf aws_rds_cluster.secondary
BC_AWS_GENERAL_69 Added /main.tf aws_rds_cluster.secondary
BC_AWS_IAM_66 Added /main.tf aws_rds_cluster.secondary
BC_AWS_GENERAL_38 Added /main.tf aws_rds_cluster.secondary
BC_AWS_IAM_59 Added /main.tf aws_rds_cluster.primary
BC_AWS_GENERAL_69 Added /main.tf aws_rds_cluster.primary
BC_AWS_IAM_66 Added /main.tf aws_rds_cluster.primary
BC_AWS_GENERAL_38 Added /main.tf aws_rds_cluster.primary
BC_AWS_GENERAL_96 Added /main.tf aws_rds_cluster.secondary
BC_AWS_GENERAL_96 Added /main.tf aws_rds_cluster.primary
BC_AWS_GENERAL_49 Added /main.tf aws_rds_cluster.secondary
BC_AWS_GENERAL_49 Added /main.tf aws_rds_cluster.primary

@nitrocode
Copy link
Member Author

/test test/bats

main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
@nitrocode
Copy link
Member Author

/test test/readme

@nitrocode
Copy link
Member Author

/test test/terratest

@nitrocode
Copy link
Member Author

/test test/bats

@nitrocode nitrocode marked this pull request as ready for review November 18, 2021 22:41
@nitrocode nitrocode requested review from a team as code owners November 18, 2021 22:41
@nitrocode nitrocode merged commit c96d859 into master Nov 19, 2021
@nitrocode nitrocode deleted the additional_inputs branch November 19, 2021 07:32
@alexjurkiewicz
Copy link
Contributor

#125 is a fix for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants