From efb84b073b2cd52e6aa98f0e7e8286aa1a631390 Mon Sep 17 00:00:00 2001 From: James Ross Date: Sat, 9 Dec 2023 18:40:20 +0000 Subject: [PATCH] chore: add changeset --- .changeset/weak-lobsters-march.md | 9 +++++++++ 1 file changed, 9 insertions(+) create mode 100644 .changeset/weak-lobsters-march.md diff --git a/.changeset/weak-lobsters-march.md b/.changeset/weak-lobsters-march.md new file mode 100644 index 00000000..94476f52 --- /dev/null +++ b/.changeset/weak-lobsters-march.md @@ -0,0 +1,9 @@ +--- +"wrangler-action": patch +--- + +Fixes issues with semver comparison, where version parts were treated lexicographically instead of numerically. + +Bulk secret uploading was introduced in wrangler `3.4.0`, and this action tries to check if the version used is greater than `3.4.0`, and then if so, using the new bulk secret API which is faster. Due to a bug in the semver comparison, `3.19.0` was being considered less than `3.4.0`, and then using an older and slower method for uploading secrets. + +Now the semver comparison is fixed, the faster bulk method is used for uploading secrets when available.