Skip to content
This repository has been archived by the owner on Mar 6, 2023. It is now read-only.

Add option for ReadOnlyPaths #338

Merged
merged 1 commit into from
Mar 16, 2021
Merged

Add option for ReadOnlyPaths #338

merged 1 commit into from
Mar 16, 2021

Conversation

SuperQ
Copy link
Collaborator

@SuperQ SuperQ commented Mar 14, 2021

Add an option to allow adding ReadOnlyPaths to systemd protection. This
is useful for allowing access to TLS certs outside of the config
directory.

  • Update README with prometheus_web_config.

[feature]

Signed-off-by: Ben Kochie superq@gmail.com

@github-actions github-actions bot added area/docs Improvements or additions to documentation area/jinja Templates area/tests Everything related to molecule tests and linters area/vars Ansible variables used in role labels Mar 14, 2021
@SuperQ SuperQ force-pushed the superq/read_only_dirs branch 4 times, most recently from 218b03f to cabeb71 Compare March 14, 2021 17:53
@SuperQ SuperQ marked this pull request as ready for review March 14, 2021 18:15
@SuperQ SuperQ requested a review from paulfantom March 14, 2021 18:15
@SuperQ
Copy link
Collaborator Author

SuperQ commented Mar 14, 2021

It took me a while to track down exactly how file.contains() works. It's literally a subshell to grep. ☹️

README.md Outdated Show resolved Hide resolved
Copy link
Member

@paulfantom paulfantom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one small nit.

Add an option to allow adding ReadOnlyPaths to systemd protection. This
is useful for allowing access to TLS certs outside of the config
directory.
* Update README with `prometheus_web_config`.

[feature]

Signed-off-by: Ben Kochie <superq@gmail.com>
Copy link
Member

@paulfantom paulfantom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/docs Improvements or additions to documentation area/jinja Templates area/tests Everything related to molecule tests and linters area/vars Ansible variables used in role
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants