Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cljr-slash behaves badly with in-ns #371

Closed
phillord opened this issue Apr 27, 2017 · 0 comments
Closed

cljr-slash behaves badly with in-ns #371

phillord opened this issue Apr 27, 2017 · 0 comments
Labels
Milestone

Comments

@phillord
Copy link

Expected behavior

When using "/" in a file using in-ns, clr-refactor should either give up, or should add requires to the namespace file.

Actual behavior

We get a illegal declaration like

(in-ns 'bob (:require [fred])

Steps to reproduce the problem

Use the slash command in a namespace with in-ns.

The problem comes about because cljr-slash uses clojure-find-ns. This actually finds either (ns) or (in-ns) forms. The refactoring is suitable for only the former.

Environment & Version information

Emacs 25.2 (trunk)
CIDER/CLojure(trunk)

clj-refactor.el version information

2.2.0

CIDER version information

Trunk``

Leiningen or Boot version

Emacs version

Operating system

Ubuntu

@expez expez added the bug label Apr 27, 2017
@benedekfazekas benedekfazekas added this to the 2.3.0 milestone Apr 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants