Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i want to embed twitter (x), the link started with x.com #16435

Closed
inilahdc opened this issue May 29, 2024 · 1 comment · Fixed by #16874 · May be fixed by #16461
Closed

i want to embed twitter (x), the link started with x.com #16435

inilahdc opened this issue May 29, 2024 · 1 comment · Fixed by #16874 · May be fixed by #16461
Assignees
@Mati365
Labels
type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 77 (v43...

Comments

@inilahdc
Copy link

📝 Provide detailed reproduction steps (if any)

  1. copy paste tweet, for example https://x.com/ckeditor/status/1781314334376722719 inside ckeditor
  3. …

✔️ Expected result

becoming embed tweet

image

❌ Actual result

just link, the embed not showing, but it still showing if the link using twitter.com

image

❓ Possible solution

add x.com to the embed detection
@inilahdc inilahdc added the type:bug This issue reports a buggy (incorrect) behavior. label May 29, 2024
@ChristopheCVB ChristopheCVB mentioned this issue Jun 3, 2024
Open
@Natshah
Copy link

Natshah commented Aug 6, 2024

Facing the same issue

@inilahdc inilahdc changed the title i want to embed twitter, and the link started with x.com i want to embed twitter (x), the link started with x.com Aug 6, 2024
@Mati365 Mati365 self-assigned this Aug 6, 2024
@Mati365 Mati365 mentioned this issue Aug 7, 2024
Merged
@Mati365 Mati365 closed this as completed in f1f049e Aug 7, 2024
@CKEditorBot CKEditorBot added this to the iteration 77 milestone Aug 7, 2024
@CKEditorBot CKEditorBot mentioned this issue Aug 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mati365 Mati365

Labels
type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 77 (v43.1.0)
4 participants
@Natshah @Mati365 @CKEditorBot @inilahdc