Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade TypeScript to v5.0 #15452

Closed
filipsobol opened this issue Dec 4, 2023 · 1 comment · Fixed by #15647
Closed

Upgrade TypeScript to v5.0 #15452

filipsobol opened this issue Dec 4, 2023 · 1 comment · Fixed by #15647
Assignees
Labels
squad:core Issue to be handled by the Core team. type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@filipsobol
Copy link
Member

filipsobol commented Dec 4, 2023

Update TypeScript from ^4.8.4 to ^5.2.2 in both core and commercial repositories.

Update TypeScript from ^4.8.4 to ^5.0.4 in both core and commercial repositories.

The work has already been done once in the core (which can be used as a reference) as part of the PoC for new installation methods, and there was a need for minor updates in 4 files in the ckeditor5-table package due to better type checking introduced in the new versions.

Please read the following changelogs to see if there are any features we can use and if there are any breaking changes that may affect projects that use our packages but still use typescript@4:

Here're changes worth and introducing (if possible):

Let's check nightly .d.ts files and test them with the QA team against TypeScript 4.7 or 4.8.


Update: TypeScript 5.3 has been released. Consider upgrading to it if you don't see any additional risks.

@filipsobol filipsobol added type:improvement This issue reports a possible enhancement of an existing feature. squad:core Issue to be handled by the Core team. labels Dec 4, 2023
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Dec 6, 2023
@pszczesniak pszczesniak self-assigned this Dec 15, 2023
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Dec 15, 2023
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Dec 21, 2023
@Witoso Witoso changed the title Upgrade TypeScript to v5.2 Upgrade TypeScript to v5.0 Jan 5, 2024
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Jan 5, 2024
@pszczesniak
Copy link
Contributor

Decision was made to update TypeScript first to 5.0.x version.

@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Jan 7, 2024
@CKEditorBot CKEditorBot added this to the iteration 70 milestone Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad:core Issue to be handled by the Core team. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
3 participants