Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace MemoryContextResetAndDeleteChildren macro with MemoryContextReset for PG 17 compatibility #332

Merged
merged 1 commit into from
May 31, 2024

Conversation

esiaero
Copy link
Contributor

@esiaero esiaero commented May 31, 2024

Hi, Postgres 17 Beta 1 is out and I noticed pg_cron has a small compatibility issue with it. This commit should fix that. It assumes pg_cron is not interested in supporting PG versions before 9.5 based on what the README implies about supported versions being PG 10 and higher.


(The following is the commit message)

MemoryContextResetAndDeleteChildren will be retired in the upcoming PG 17 [0]. It has been equivalent to MemoryContextReset since PG 9.5 [1]. The reference to MemoryContextResetAndDeleteChildren is thus replaced by MemoryContextReset for compatibility purposes.

[0] postgres/postgres@6a72c42

[1] postgres/postgres@eaa5808

…eset

MemoryContextResetAndDeleteChildren will be retired in the upcoming PG 17 [0].
It has been equivalent to MemoryContextReset since PG 9.5 [1]. The reference to
MemoryContextResetAndDeleteChildren is thus replaced by MemoryContextReset for
compatibility purposes.

[0] postgres/postgres@6a72c42

[1] postgres/postgres@eaa5808
@esiaero esiaero changed the title Replace MemoryContextResetAndDeleteChildren macro with MemoryContextReset Replace MemoryContextResetAndDeleteChildren macro with MemoryContextReset for PG 17 compatibility May 31, 2024
@marcoslot
Copy link
Collaborator

Thanks!

@marcoslot marcoslot merged commit e2a6143 into citusdata:main May 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants